All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, thierry.reding@avionic-design.de,
	Nios2 development list <nios2-dev@sopc.et.ntust.edu.tw>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: Add netdev_alloc_skb_ip_align() helper
Date: Thu, 08 Oct 2009 12:36:57 +0800	[thread overview]
Message-ID: <4ACD6C69.7040206@wytron.com.tw> (raw)
In-Reply-To: <4ACD585B.5080106@gmail.com>

On 10/08/2009 11:11 AM, Eric Dumazet wrote:
> Thomas Chou a écrit :
> You should do :
>
> size -= 4; /* strip the CRC */
> skb = netdev_alloc_skb(dev, size + NET_IP_ALIGN);
> if (skb) {
> 	skb_reserve(skb, NET_IP_ALIGN);
> 	...
> }
>
>
> Please check other implementations...
>
> David, maybe we should add following helper :
>
> [PATCH] net: Add netdev_alloc_skb_ip_align() helper

Hi Eric,

Thanks for the suggestion. I will follow your commit and send revised patch.

- Thomas

  reply	other threads:[~2009-10-08  4:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08  2:32 [PATCH] ethoc: use NET_IP_ALIGN in skb_reserve() Thomas Chou
2009-10-08  3:11 ` [PATCH] net: Add netdev_alloc_skb_ip_align() helper Eric Dumazet
2009-10-08  4:36   ` Thomas Chou [this message]
2009-10-08  5:40   ` David Miller
2009-10-09 16:31     ` Eric Dumazet
2009-10-10  3:43       ` David Miller
2009-10-13 10:45   ` David Miller
2009-10-13 15:34     ` Eric Dumazet
2009-10-13 17:30       ` Stephen Hemminger
2009-10-13 18:06         ` Eric Dumazet
2009-10-13 18:53       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACD6C69.7040206@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nios2-dev@sopc.et.ntust.edu.tw \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.