From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mvrvz-0007wO-Kg for mharc-grub-devel@gnu.org; Thu, 08 Oct 2009 08:17:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mvrvx-0007vx-Kk for grub-devel@gnu.org; Thu, 08 Oct 2009 08:17:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mvrvt-0007vF-0c for grub-devel@gnu.org; Thu, 08 Oct 2009 08:17:25 -0400 Received: from [199.232.76.173] (port=39483 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mvrvs-0007vA-Ri for grub-devel@gnu.org; Thu, 08 Oct 2009 08:17:20 -0400 Received: from mail-fx0-f205.google.com ([209.85.220.205]:32939) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mvrvs-0008QV-HK for grub-devel@gnu.org; Thu, 08 Oct 2009 08:17:20 -0400 Received: by fxm1 with SMTP id 1so5015794fxm.31 for ; Thu, 08 Oct 2009 05:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=fB3f/dqRQpNjoLQ0ZyrcN2o6htMqD0/UwxzdjgKWBAE=; b=AxOiGtS16ldm5lzFQuIVzSZjB+6cUtTo09cQLS1mhBjemK1qpDbTYL4WG7FqeSoTlV qYjREtOTWxZoWecJ9lkAIq2Mmi3SK0yZ/RLX0lyeED0Aht0oLwDsR753LR7HuvH7AUOh S1FtMmpam41rE//PEySyZW5IOWiBYrIZJysME= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=u+7xwgd6aQbrrUHZVjQJ/r78PoeILKyULwtzRKHKq+Y8UvbhEO4PlfSikZAZL1o0Ta SRuBKVbzO18jJsE3SPZeg9IbFIxCutx/doro9fm/7MIXY1qDTHVDziXgGwAdwkwZkkIS fP4xrLBwj1KPcpCNW0+ZUgMQO6sOFVlmcJgj8= Received: by 10.204.34.205 with SMTP id m13mr974302bkd.80.1255004238816; Thu, 08 Oct 2009 05:17:18 -0700 (PDT) Received: from debian.bg45.phnet (hpx-public-dock-152-dhcp.ethz.ch [82.130.83.152]) by mx.google.com with ESMTPS id p17sm1249263fka.12.2009.10.08.05.17.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 08 Oct 2009 05:17:17 -0700 (PDT) Message-ID: <4ACDD84C.4030102@gmail.com> Date: Thu, 08 Oct 2009 14:17:16 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20091007211334.GA31055@thorin> <1254996731.2857.13.camel@fz.local> In-Reply-To: <1254996731.2857.13.camel@fz.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2009 12:17:25 -0000 Felix Zielcke wrote: > Am Mittwoch, den 07.10.2009, 23:13 +0200 schrieb Robert Millan: > > >> (grub_cpuid_has_longmode): ... this. Update all users. Remove >> `unsigned' attribute. >> > > I think that should be `static' not `unsigned': > > -static unsigned char has_longmode = 0; > +unsigned char grub_cpuid_has_longmode = 0; > > But don't we need to add now an `insmod cpuid' in grub-mkconfig so that > this actually works / is useful? > Or does the cpuid command get loaded automatically somewhere already? > > It gets loaded because of symbol dependency of bsd.mod on grub_cpuid_has_longmode -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git