All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: "xenomai@xenomai.org" <xenomai@xenomai.org>,
	"oliver.schlenker@domain.hid" <oliver.schlenker@domain.hid>
Subject: Re: [Xenomai-help] Re : rt_printf with daemonized task
Date: Thu, 08 Oct 2009 14:19:02 +0200	[thread overview]
Message-ID: <4ACDD8B6.4020902@domain.hid> (raw)
In-Reply-To: <4ACDBBF8.6090007@domain.hid>

Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> Jan Kiszka wrote:
>>> Gilles Chanteperdrix wrote:
>>>> oliver.schlenker@domain.hid wrote:
>>>>>>> int main( int arc, char *argv[] ) { int i;
>>>>>>>
>>>>>>> rt_print_auto_init(1);
>>>>>>>
>>>>>>> rt_printf("--------------- TEST RT-PRINTF  1 ------------\n");
>>>>>>>
>>>>>>> sleep(1);
>>>>>>>
>>>>>>> daemon(0,0);
>>>>>>>
>>>>>>> rt_print_auto_init(1);
>>>>> Ok, understood, at least for the scenario where the rt_print feature
>>>>> is initialised befor the fork/daemon call. What I don't understand
>>>>> is, why it does not work if the rt_print feature is initialised after
>>>>> the fork / daemon.
>>>> From the way I understand your code, you never tried to initialize the
>>>> rt_print feature only after the fork, your code initializes it both
>>>> before and after.
>>>>
>>> There are two initializations: The base init done via __rt_print_init on
>>> library loading and the one to be done per-thread via rt_print_init (or
>>> on first rt_printf). That printer thread is initialized via the former
>>> one. On fork, we do not need to re-run the full __rt_print_init
>>> (variables and resources are cloned on fork), we just need to spawn
>>> another printer thread.
>> Unless I am wrong, rtdk also maintains a list of the thread buffers
>> which need to be polled. After the fork, this list will be intact, but
>> the threads to which belong the buffers will no longer exist. So, IMO,
>> the fork handler should also free all these buffers and reset the list
>> to the empty state.
> 
> Famous last words: That should work without tweaking. A print_buffer
> only contains data references, nothing that points to some uncloned thread.

Ok. But you walk the list of print_buffers every time, and these
print_buffers remain allocated in the child process. So, that is a kind
of memory leak.

> 
> Jan
> 


-- 
                                          Gilles



  reply	other threads:[~2009-10-08 12:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08  7:22 [Xenomai-help] Re : rt_printf with daemonized task oliver.schlenker
2009-10-08  8:26 ` Gilles Chanteperdrix
2009-10-08  9:26   ` Jan Kiszka
2009-10-08  9:33     ` Gilles Chanteperdrix
2009-10-08 10:16       ` Jan Kiszka
2009-10-08 12:19         ` Gilles Chanteperdrix [this message]
2009-10-08 13:08           ` Jan Kiszka
  -- strict thread matches above, loose matches on Subject: below --
2009-10-08 13:21 oliver.schlenker
2009-10-08 13:27 ` Jan Kiszka
2009-10-08 13:33 ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACDD8B6.4020902@domain.hid \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=jan.kiszka@domain.hid \
    --cc=oliver.schlenker@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.