All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com
Subject: Re: [PATCH] qemu-kvm: move msi-x to Makefile.target
Date: Thu, 08 Oct 2009 15:21:26 +0200	[thread overview]
Message-ID: <4ACDE756.7030807@redhat.com> (raw)
In-Reply-To: <4ACDE1C6.1020208@redhat.com>

On 10/08/2009 02:57 PM, Avi Kivity wrote:
> On 10/08/2009 02:43 PM, Avi Kivity wrote:
>> On 10/06/2009 02:21 PM, Michael S. Tsirkin wrote:
>>> KVM interrupt injection support depends on target,
>>> so MSI-X needs to be in Makefile.target for interrupt
>>> injection to work. We'll be able to clean it up once
>>> interrupt injection is upstream.
>>>
>>> This fixes virtio breakage with kvm caused by 263b7947327e13.
>>>
>>
>> Applied, thanks.
>>
>
> Er, this doesn't build:
>
> In file included from /home/avi/qemu-kvm/hw/msix.c:18:
> /home/avi/qemu-kvm/qemu-kvm.h:1234: error: field ‘kvm_sw_breakpoints’ 
> has incomplete type
>
> Dropped.
>

And re-applied, after seeing your previous fix.

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2009-10-08 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 12:21 [PATCH] qemu-kvm: move msi-x to Makefile.target Michael S. Tsirkin
2009-10-08 12:43 ` Avi Kivity
2009-10-08 12:57   ` Avi Kivity
2009-10-08 13:21     ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACDE756.7030807@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.