From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>,
qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] provide in-kernel ioapic
Date: Thu, 08 Oct 2009 15:54:11 +0200 [thread overview]
Message-ID: <4ACDEF03.6010406@redhat.com> (raw)
In-Reply-To: <4ACDEDEC.60706@us.ibm.com>
On 10/08/2009 03:49 PM, Anthony Liguori wrote:
> Glauber Costa wrote:
>> This patch provides kvm with an in-kernel ioapic. We are currently
>> not enabling it.
>> The code is heavily based on what's in qemu-kvm.git.
>
> It really ought to be it's own file and own device model. Having the
> code mixed in with ioapic.c is confusing because it's unclear what
> code is in use when the in-kernel model is used.
I disagree. It's the same device with the same guest-visible interface
and the same host-visible interface (save/restore, 'info ioapic' if we
write one). Splitting it into two files will only result in code
duplication.
Think of it as an ioapic accelerator.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-10-08 13:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1254953315-5761-1-git-send-email-glommer@redhat.com>
[not found] ` <1254953315-5761-2-git-send-email-glommer@redhat.com>
[not found] ` <1254953315-5761-3-git-send-email-glommer@redhat.com>
[not found] ` <1254953315-5761-4-git-send-email-glommer@redhat.com>
2009-10-08 13:49 ` [PATCH v2 3/9] provide in-kernel ioapic Anthony Liguori
2009-10-08 13:54 ` Avi Kivity [this message]
2009-10-08 15:53 ` Jan Kiszka
2009-10-08 16:07 ` [Qemu-devel] " Jamie Lokier
2009-10-08 16:12 ` Anthony Liguori
2009-10-08 16:17 ` Avi Kivity
2009-10-08 16:22 ` Gleb Natapov
2009-10-08 16:29 ` Avi Kivity
2009-10-08 16:34 ` Gleb Natapov
2009-10-08 16:42 ` Avi Kivity
2009-10-08 17:11 ` Gleb Natapov
2009-10-09 10:02 ` Jamie Lokier
2009-10-09 12:02 ` [Qemu-devel] " Gleb Natapov
2009-10-09 14:32 ` Glauber Costa
2009-10-09 16:49 ` [Qemu-devel] " Jamie Lokier
2009-10-09 19:55 ` Juan Quintela
2009-10-09 21:34 ` Glauber Costa
2009-10-12 13:20 ` Anthony Liguori
2009-10-12 14:18 ` Jamie Lokier
2009-10-12 14:49 ` Anthony Liguori
[not found] ` <1254953315-5761-5-git-send-email-glommer@redhat.com>
2009-10-08 13:55 ` [PATCH v2 4/9] provide in-kernel apic Anthony Liguori
2009-10-08 14:09 ` Avi Kivity
2009-10-08 14:22 ` [Qemu-devel] " Glauber Costa
2009-10-09 10:06 ` Jamie Lokier
2009-10-09 14:30 ` Glauber Costa
2009-10-09 16:48 ` [Qemu-devel] " Jamie Lokier
2009-10-09 18:06 ` Glauber Costa
2009-10-09 19:49 ` [Qemu-devel] " Anthony Liguori
2009-10-11 9:10 ` Avi Kivity
2009-10-12 13:41 ` [Qemu-devel] " Anthony Liguori
2009-10-08 14:26 ` Anthony Liguori
2009-10-08 14:31 ` Avi Kivity
2009-10-08 14:39 ` Anthony Liguori
2009-10-08 14:46 ` Glauber Costa
2009-10-08 14:44 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACDEF03.6010406@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.