From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Vegard Nossum <vegard.nossum@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] net: Fix struct sock bitfield annotation
Date: Thu, 08 Oct 2009 17:16:13 +0200 [thread overview]
Message-ID: <4ACE023D.9030208@gmail.com> (raw)
Since commit a98b65a3 (net: annotate struct sock bitfield), we lost 8 bytes
in struct sock on 64bits arches because of kmemcheck_bitfield_end(flags) misplacement.
struct good {
int begin_flags[0];
unsigned char a : 8;
unsigned char b;
unsigned short c;
int end_flags[0];
int sk_rcvbuf;
void *ptr;
};
struct bad {
int begin_flags[0];
unsigned char a : 8;
int end_flags[0];
unsigned char b;
unsigned short c;
int sk_rcvbuf;
void *ptr;
};
sizeof(struct good) = 16, sizeof(struct bad) = 24
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
include/net/sock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 1621935..ecfb831 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -229,9 +229,9 @@ struct sock {
unsigned char sk_shutdown : 2,
sk_no_check : 2,
sk_userlocks : 4;
- kmemcheck_bitfield_end(flags);
unsigned char sk_protocol;
unsigned short sk_type;
+ kmemcheck_bitfield_end(flags);
int sk_rcvbuf;
socket_lock_t sk_lock;
/*
next reply other threads:[~2009-10-08 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 15:16 Eric Dumazet [this message]
2009-10-08 21:31 ` [PATCH] net: Fix struct sock bitfield annotation David Miller
2009-10-08 21:54 ` Vegard Nossum
2009-10-08 22:08 ` David Miller
2009-10-09 1:07 ` Eric Dumazet
2009-10-09 1:46 ` Eric Dumazet
2009-10-09 19:39 ` Christoph Lameter
2009-10-09 20:41 ` Eric Dumazet
2009-10-13 21:59 ` [RFC net-next-2.6] udp: Dont use lock_sock()/release_sock() in rx path Eric Dumazet
2009-10-09 7:54 ` [PATCH] net: Fix struct sock bitfield annotation David Miller
2009-10-09 8:50 ` Eric Dumazet
2009-10-12 6:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACE023D.9030208@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.