From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [RFC 1/3] BKL pushdown from do_new_mount() to the filesystems Date: Thu, 08 Oct 2009 10:49:32 -0500 Message-ID: <4ACE0A0C.2030701@panasas.com> References: <1254324604-20243-1-git-send-email-jblunck@suse.de> <1254324604-20243-2-git-send-email-jblunck@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Jan Blunck Return-path: Received: from dip-colo-pa.panasas.com ([67.152.220.67]:32417 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758662AbZJHPuP (ORCPT ); Thu, 8 Oct 2009 11:50:15 -0400 In-Reply-To: <1254324604-20243-2-git-send-email-jblunck@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jan Blunck wrote > diff --git a/fs/exofs/super.c b/fs/exofs/super.c > index 9f500de..ea045b8 100644 > --- a/fs/exofs/super.c > +++ b/fs/exofs/super.c > @@ -297,9 +297,13 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > struct osd_obj_id obj; > int ret; > > + lock_kernel(); > + > sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); > - if (!sbi) > + if (!sbi) { > + unlock_kernel(); > return -ENOMEM; > + } > sb->s_fs_info = sbi; > > /* use mount options to fill superblock */ > @@ -399,6 +403,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > out: > if (or) > osd_end_request(or); > + unlock_kernel(); > return ret; > > free_sbi: You can add the revert of this patch to your series when submitted. We don't need the BKL in exofs. Signed-off-by: Boaz Harrosh @@ -297,13 +297,9 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) struct osd_obj_id obj; int ret; - lock_kernel(); - sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); - if (!sbi) { - unlock_kernel(); + if (!sbi) return -ENOMEM; - } sb->s_fs_info = sbi; /* use mount options to fill superblock */ @@ -399,7 +403,6 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) out: if (or) osd_end_request(or); - unlock_kernel(); return ret; free_sbi: