All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 1/4] [LIBNETFILTER_CONNTRACK] api: use ANSI style function declarations
       [not found] ` <20091007123835.5204.7065.stgit@lb64>
@ 2009-10-08 16:00   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2009-10-08 16:00 UTC (permalink / raw)
  To: Hannes Eder; +Cc: Netfilter Development Mailinglist

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/4] [LIBNETFILTER_CONNTRACK] make symbols used only in file scope static
       [not found] ` <20091007123847.5204.3736.stgit@lb64>
@ 2009-10-08 16:01   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2009-10-08 16:01 UTC (permalink / raw)
  To: Hannes Eder; +Cc: Netfilter Development Mailinglist

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>

Also applied.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/4] [LIBNETFILTER_CONNTRACK] snprintf: remove duplicate initializer entry
       [not found] ` <20091007123902.5204.28787.stgit@lb64>
@ 2009-10-08 16:02   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2009-10-08 16:02 UTC (permalink / raw)
  To: Hannes Eder; +Cc: Netfilter Development Mailinglist

Hannes Eder wrote:
> diff --git a/src/conntrack/snprintf.c b/src/conntrack/snprintf.c
> index 452d62f..1104c63 100644
> --- a/src/conntrack/snprintf.c
> +++ b/src/conntrack/snprintf.c
> @@ -21,7 +21,6 @@ const char *proto2str[IPPROTO_MAX] = {
>  	[IPPROTO_ICMPV6]		= "icmpv6",
>  	[IPPROTO_SCTP]			= "sctp",
>  	[IPPROTO_GRE]			= "gre",
> -	[IPPROTO_UDPLITE]		= "udplite",
>  	[IPPROTO_DCCP]			= "dccp",
>  };

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/4] [LIBNETFILTER_CONNTRACK] api: remove dead code (nfexp_parse_expect)
       [not found] ` <20091007123911.5204.10713.stgit@lb64>
@ 2009-10-08 16:03   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2009-10-08 16:03 UTC (permalink / raw)
  To: Hannes Eder; +Cc: Netfilter Development Mailinglist

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>
> ---
> I am not sure about this one, it just popped up after making
> symbols that are just used in file scope static.  This might be
> a function the you would like to export, so a proper fix would be
> adding it to the header file.

Oh, I see. I think that we also need to export nfexp_build* functions to
provide an API similar to the conntrack API. Let me think what to do
with this. So far, nobody has used them though.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-10-08 16:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20091007123624.5204.92195.stgit@lb64>
     [not found] ` <20091007123835.5204.7065.stgit@lb64>
2009-10-08 16:00   ` [PATCH 1/4] [LIBNETFILTER_CONNTRACK] api: use ANSI style function declarations Pablo Neira Ayuso
     [not found] ` <20091007123847.5204.3736.stgit@lb64>
2009-10-08 16:01   ` [PATCH 2/4] [LIBNETFILTER_CONNTRACK] make symbols used only in file scope static Pablo Neira Ayuso
     [not found] ` <20091007123902.5204.28787.stgit@lb64>
2009-10-08 16:02   ` [PATCH 3/4] [LIBNETFILTER_CONNTRACK] snprintf: remove duplicate initializer entry Pablo Neira Ayuso
     [not found] ` <20091007123911.5204.10713.stgit@lb64>
2009-10-08 16:03   ` [PATCH 4/4] [LIBNETFILTER_CONNTRACK] api: remove dead code (nfexp_parse_expect) Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.