Re: [PATCH 1/4] [LIBNETFILTER_CONNTRACK] api: use ANSI style function declarations

Re: [PATCH 1/4] [LIBNETFILTER_CONNTRACK] api: use ANSI style function declarations

[Pablo Neira Ayuso]

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>

Applied, thanks.

Re: [PATCH 2/4] [LIBNETFILTER_CONNTRACK] make symbols used only in file scope static

[Pablo Neira Ayuso]

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>

Also applied.

Re: [PATCH 3/4] [LIBNETFILTER_CONNTRACK] snprintf: remove duplicate initializer entry

[Pablo Neira Ayuso]

Hannes Eder wrote:
> diff --git a/src/conntrack/snprintf.c b/src/conntrack/snprintf.c
> index 452d62f..1104c63 100644
> --- a/src/conntrack/snprintf.c
> +++ b/src/conntrack/snprintf.c
> @@ -21,7 +21,6 @@ const char *proto2str[IPPROTO_MAX] = {
>  	[IPPROTO_ICMPV6]		= "icmpv6",
>  	[IPPROTO_SCTP]			= "sctp",
>  	[IPPROTO_GRE]			= "gre",
> -	[IPPROTO_UDPLITE]		= "udplite",
>  	[IPPROTO_DCCP]			= "dccp",
>  };

Applied, thanks!

Re: [PATCH 4/4] [LIBNETFILTER_CONNTRACK] api: remove dead code (nfexp_parse_expect)

[Pablo Neira Ayuso]

Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>
> ---
> I am not sure about this one, it just popped up after making
> symbols that are just used in file scope static.  This might be
> a function the you would like to export, so a proper fix would be
> adding it to the header file.

Oh, I see. I think that we also need to export nfexp_build* functions to
provide an API similar to the conntrack API. Let me think what to do
with this. So far, nobody has used them though.