From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hannes Eder <heder@google.com>
Cc: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 4/4] [LIBNETFILTER_CONNTRACK] api: remove dead code (nfexp_parse_expect)
Date: Thu, 08 Oct 2009 18:03:39 +0200 [thread overview]
Message-ID: <4ACE0D5B.80704@netfilter.org> (raw)
In-Reply-To: <20091007123911.5204.10713.stgit@lb64>
Hannes Eder wrote:
> Signed-off-by: Hannes Eder <heder@google.com>
> ---
> I am not sure about this one, it just popped up after making
> symbols that are just used in file scope static. This might be
> a function the you would like to export, so a proper fix would be
> adding it to the header file.
Oh, I see. I think that we also need to export nfexp_build* functions to
provide an API similar to the conntrack API. Let me think what to do
with this. So far, nobody has used them though.
prev parent reply other threads:[~2009-10-08 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091007123624.5204.92195.stgit@lb64>
[not found] ` <20091007123835.5204.7065.stgit@lb64>
2009-10-08 16:00 ` [PATCH 1/4] [LIBNETFILTER_CONNTRACK] api: use ANSI style function declarations Pablo Neira Ayuso
[not found] ` <20091007123847.5204.3736.stgit@lb64>
2009-10-08 16:01 ` [PATCH 2/4] [LIBNETFILTER_CONNTRACK] make symbols used only in file scope static Pablo Neira Ayuso
[not found] ` <20091007123902.5204.28787.stgit@lb64>
2009-10-08 16:02 ` [PATCH 3/4] [LIBNETFILTER_CONNTRACK] snprintf: remove duplicate initializer entry Pablo Neira Ayuso
[not found] ` <20091007123911.5204.10713.stgit@lb64>
2009-10-08 16:03 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACE0D5B.80704@netfilter.org \
--to=pablo@netfilter.org \
--cc=heder@google.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.