From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 3/3] Fix compilation issues with
	CONFIG_DRM_TTM enabled.
Date: Thu, 08 Oct 2009 11:41:39 -0700
Message-ID: <4ACE3263.7000609@goop.org>
References: <1255022590-9578-1-git-send-email-konrad.wilk@oracle.com>
	<1255022590-9578-2-git-send-email-konrad.wilk@oracle.com>
	<1255022590-9578-3-git-send-email-konrad.wilk@oracle.com>
	<1255022590-9578-4-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1255022590-9578-4-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 10/08/09 10:23, Konrad Rzeszutek Wilk wrote:
> The recent fix for GART on Xen included an extra include which
> caused the build to choke when building the ttm drivers.
>   

How does the compile fail?  (Generally its best to include the
compilation error messages when submitting a compile-fix patch.)

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  arch/x86/include/asm/agp.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/agp.h b/arch/x86/include/asm/agp.h
> index 8107b71..3282ea6 100644
> --- a/arch/x86/include/asm/agp.h
> +++ b/arch/x86/include/asm/agp.h
> @@ -3,7 +3,6 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/cacheflush.h>
> -#include <asm/dma-mapping.h>
>   

The code below uses dma_alloc/free_coherent, so it needs some header for
the prototypes.  Perhaps it should be linux/dma-mapping.h?

    J