From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mw27y-0003pE-3O for mharc-grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mw27u-0003m4-EE for grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mw27o-0003eX-Ei for grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:24 -0400 Received: from [199.232.76.173] (port=54231 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mw27n-0003e3-Sm for grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:19 -0400 Received: from mx20.gnu.org ([199.232.41.8]:52540) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mw27n-0000KM-46 for grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:19 -0400 Received: from mail-ew0-f228.google.com ([209.85.219.228]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mw27m-0002Ei-G4 for grub-devel@gnu.org; Thu, 08 Oct 2009 19:10:18 -0400 Received: by ewy28 with SMTP id 28so12174258ewy.42 for ; Thu, 08 Oct 2009 16:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=zjGhu9ElpLwO9vRaPOBt8z7cjr1loOTH+wm2aMGupaw=; b=GZ234hPK/Zmn8fB8xjwRUEszt42toV/45IbPcadrVdpuRNFMX+52kGW2eWE7Mlw85D 8rTts/3u2MbI+oOExDWkEuudxgJAMAkP/S1apsP4lypfK/0WUpH0Mj/WKBMqKUcH++Xz 8roiFisbARHvZo2AGXEuw3DDzIssAnaRQUeyw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=C0PO5mMbrR9JX3eChTLbGbrkbtWOzduxCMf/RBWaf/1RpA/AQ4nmcBB63ui1Q/yMur xD20NIMSYIpNgldCT9Reir5H5RYkN8GzOfwMKUjlugMXXSMp4Ld5TlGKmQVew5c8amEd FRHUkpLYltmF1f8GY4P+GWFKxAnFEZWmKhF/8= Received: by 10.211.172.11 with SMTP id z11mr8901759ebo.93.1255043416690; Thu, 08 Oct 2009 16:10:16 -0700 (PDT) Received: from debian.bg45.phnet (gprs25.swisscom-mobile.ch [193.247.250.25]) by mx.google.com with ESMTPS id 23sm581846eya.46.2009.10.08.16.10.14 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 08 Oct 2009 16:10:14 -0700 (PDT) Message-ID: <4ACE7154.9020405@gmail.com> Date: Fri, 09 Oct 2009 01:10:12 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20091007211334.GA31055@thorin> In-Reply-To: <20091007211334.GA31055@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2009 23:10:27 -0000 >Index: include/grub/i386/cpuid.h >=================================================================== >--- include/grub/i386/cpuid.h (revision 0) >+++ include/grub/i386/cpuid.h (revision 0) This file doesn't follow convention of having an ifdef around the file >+extern unsigned char grub_cpuid_has_longmode; I don't like it being declared as a variable: user may inadvertently assign a value to it. I would be more confortable with a function Other than that patch looks good -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git