From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irda/sa1100_ir: check return value of startup hook
Date: Fri, 09 Oct 2009 16:14:52 +0400 [thread overview]
Message-ID: <4ACF293C.7070803@ru.mvista.com> (raw)
In-Reply-To: <1255073153-24962-1-git-send-email-mad_soft@inbox.ru>
Hello.
Dmitry Artamonow wrote:
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
[...]
> diff --git a/drivers/net/irda/sa1100_ir.c b/drivers/net/irda/sa1100_ir.c
> index 38bf7cf..df5db2d 100644
> --- a/drivers/net/irda/sa1100_ir.c
> +++ b/drivers/net/irda/sa1100_ir.c
> @@ -232,8 +232,11 @@ static int sa1100_irda_startup(struct sa1100_irda *si)
> /*
> * Ensure that the ports for this device are setup correctly.
> */
> - if (si->pdata->startup)
> - si->pdata->startup(si->dev);
> + if (si->pdata->startup) {
> + ret = si->pdata->startup(si->dev);
> + if (ret)
> + return ret;
> + }
Overindented brace.
>
> /*
> * Configure PPC for IRDA - we want to drive TXD2 low.
WBR, Sergei
next prev parent reply other threads:[~2009-10-09 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 7:25 [PATCH] irda/sa1100_ir: check return value of startup hook Dmitry Artamonow
2009-10-09 12:14 ` Sergei Shtylyov [this message]
2009-10-09 20:12 ` Dmitry Artamonow
2009-10-13 10:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACF293C.7070803@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.