From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MwMFW-0001qg-PR for mharc-grub-devel@gnu.org; Fri, 09 Oct 2009 16:39:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MwMFV-0001pQ-4r for grub-devel@gnu.org; Fri, 09 Oct 2009 16:39:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MwMFQ-0001k8-Dh for grub-devel@gnu.org; Fri, 09 Oct 2009 16:39:36 -0400 Received: from [199.232.76.173] (port=45850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MwMFQ-0001jw-8j for grub-devel@gnu.org; Fri, 09 Oct 2009 16:39:32 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:61663) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MwMFP-0002bC-S4 for grub-devel@gnu.org; Fri, 09 Oct 2009 16:39:32 -0400 Received: by fg-out-1718.google.com with SMTP id 22so2319824fge.12 for ; Fri, 09 Oct 2009 13:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=qqEG1FOzn+1I8qf1KAC5gXcCjc3H0ryTY1Iy1cVjpC4=; b=IqgH+pcD6yM9dx8A7Zx5yrS390MW6n0Zxv0D/MOGVc8aFs6OOJItekc7sa7KXmJ7KB w1UqnIBjkoyiidg7vWBByBWF+RrvHxaLr1C/+s57P2lyErMtSP8k1BJlSUkmfSxWrH3s Zo+KNECbf4kAVHgzRheiLeRWUm8Y8cAbjVwlo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=qAnB2HUMFr2+NlYStPAB5xJS2/gjT6YezX6pmtjFG0PwmqFEZMBQENnzanx46wUmDI CFx1fNh88PC1VcbbUbmEsSO6RDtYPcbtYUM2CQoIcbzmHyoWgSWwybShQLwjfPD4UYwT sCWIYUpuQsQr83uQZfUmWIe85l3cz2fp7gU1k= Received: by 10.86.227.13 with SMTP id z13mr2853170fgg.72.1255120770072; Fri, 09 Oct 2009 13:39:30 -0700 (PDT) Received: from debian.bg45.phnet (118-136.203-62.cust.bluewin.ch [62.203.136.118]) by mx.google.com with ESMTPS id 4sm643338fge.17.2009.10.09.13.39.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Oct 2009 13:39:28 -0700 (PDT) Message-ID: <4ACF9F7E.7010408@gmail.com> Date: Fri, 09 Oct 2009 22:39:26 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20091007211334.GA31055@thorin> <4ACE7154.9020405@gmail.com> <20091009182553.GD4645@thorin> In-Reply-To: <20091009182553.GD4645@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2009 20:39:37 -0000 Robert Millan wrote: > Hi, > > I didn't notice this mail untill a few minutes ago (was still in fetch > queue), so my first patch was already checked in. > > On Fri, Oct 09, 2009 at 01:10:12AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >>> Index: include/grub/i386/cpuid.h >>> =================================================================== >>> --- include/grub/i386/cpuid.h (revision 0) >>> +++ include/grub/i386/cpuid.h (revision 0) >>> >> This file doesn't follow convention of having an ifdef around the file >> > > Thanks, I've added it now. > > >>> +extern unsigned char grub_cpuid_has_longmode; >>> >> I don't like it being declared as a variable: user may inadvertently assign a value to it. I would be more confortable with a function >> > > I tend to prefer a (const) function too, but this required some restructuring > in cpuid.c so for 1.97 I opted for keeping the changes minimal. > > Why would these changes be intrusive? It's just a function returning a static value or did I miss something? -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git