All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Duplication of vdso and vsyscall code?
Date: Fri, 09 Oct 2009 14:15:58 -0700	[thread overview]
Message-ID: <4ACFA80E.7050701@goop.org> (raw)

arch/x86/kernel/vsyscall_64.c implements vgettimeofday and vgetcpu. 
(And vtime)

arch/x86/vdso/vclock_gettime.c implements __vdso_gettimeofday (and
__vdso_clock_gettime), and vgetcpu.c has __vdso_getcpu.

These appear to be functionally identical duplicate definitions.   I
don't understand the history here to know how we came to get two sets of
these functions, but surely we can share the same code for both of these?

Thanks,
    J

             reply	other threads:[~2009-10-09 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 21:15 Jeremy Fitzhardinge [this message]
2009-10-10  4:14 ` Duplication of vdso and vsyscall code? Andi Kleen
2009-10-10  4:47   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACFA80E.7050701@goop.org \
    --to=jeremy@goop.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.