From: Nishanth Menon <nm@ti.com>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Premi, Sanjeev" <premi@ti.com>
Subject: Re: [PATCH] OMAP3:PM: introduce enabled flag to omap_opp
Date: Fri, 9 Oct 2009 16:25:24 -0500 [thread overview]
Message-ID: <4ACFAA44.80901@ti.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE89444CC6CD18@dlee02.ent.ti.com>
Madhu, Sergio,
Aguirre Rodriguez, Sergio Alberto had written, on 10/09/2009 04:17 PM,
the following:
>> - {S125M, VDD1_OPP1, 0x1E},
>> + {true, S125M, VDD1_OPP1, 0x1E, true},
>
> The last "true" here is wrong.
>
> Should just be:
> {true, S125M, VDD1_OPP1, 0x1E},
thanks.. that is thanks to my hasty patch hand edition... apologies on
the noise. :( I will send out a v2.
Madhu,
>> We used to enable and disable OPPs based on
>> rate being set to 0, this has been confusing in
>> general. So, allow specific OPPs to be now
>> enabled/disabled by an explicit enabled flag.
>>
>
> A dumb question, what is the intention of this flag?
>
the idea was to allow a field to properly disable the OPP instead of
reusing rate flag itself.
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2009-10-09 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 20:27 [PATCH] OMAP3:PM: introduce enabled flag to omap_opp Nishanth Menon
2009-10-09 21:10 ` Madhusudhan
2009-10-09 21:17 ` Aguirre Rodriguez, Sergio Alberto
2009-10-09 21:25 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACFAA44.80901@ti.com \
--to=nm@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.