All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rix <tom@bumblecow.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup
Date: Sun, 11 Oct 2009 11:54:36 -0500	[thread overview]
Message-ID: <4AD20DCC.5000101@bumblecow.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D932688DA@dlee01.ent.ti.com>

Paulraj, Sandeep wrote:
>> The offset to the chip select is incorrect.
>>
>> The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,
>>
>> omap3: embedd gpmc_cs into gpmc config struct
>>
>> introduced a problem with the serial gpmc setup.
>>
>> This patch reverts the chip select to its previous value.
>>
>> The symptoms of this problem are that the Zoom2
>> currently hangs.
>>
>> This was run tested on Zoom2.
>>
>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>> ---
>>  board/logicpd/zoom2/zoom2.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/board/logicpd/zoom2/zoom2.c b/board/logicpd/zoom2/zoom2.c
>> index d9e2ae5..cd8c9fe 100644
>> --- a/board/logicpd/zoom2/zoom2.c
>> +++ b/board/logicpd/zoom2/zoom2.c
>> @@ -129,7 +129,7 @@ int board_init (void)
>>
>>  	/* Configure console support on zoom2 */
>>  	gpmc_config = gpmc_serial_TL16CP754C;
>> -	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
>> +	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
>>  			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
>>
>>  	/* board id for Linux */
>> --
>> 1.6.0.6
> 
> 
> Tom,
> 
> I'll push this the moment we resolves some of our OMAP3 issues.
> 

Thanks!
Tom

> Thanks,
> Sandeep
> 
> 

  reply	other threads:[~2009-10-11 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 22:19 [U-Boot] Zoom2 Fix serial setup Tom Rix
2009-10-05 22:19 ` [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup Tom Rix
2009-10-11 16:23   ` Paulraj, Sandeep
2009-10-11 16:54     ` Tom Rix [this message]
2009-10-12 16:12       ` Paulraj, Sandeep

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD20DCC.5000101@bumblecow.com \
    --to=tom@bumblecow.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.