From: Kevin Wolf <kwolf@redhat.com>
To: adam@os.inf.tu-dresden.de
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] multiboot: Limit number of multiboot modules
Date: Mon, 12 Oct 2009 12:43:38 +0200 [thread overview]
Message-ID: <4AD3085A.1050906@redhat.com> (raw)
In-Reply-To: <1255268921-5403-2-git-send-email-adam@os.inf.tu-dresden.de>
Am 11.10.2009 15:48, schrieb adam@os.inf.tu-dresden.de:
> From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
>
> Add size checks to avoid overwriting the multiboot structure
> when too many modules are loaded.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Looks correct, too, and is definitely an improvement over the current
code. But can't we make it more dynamic in a second step? I don't like
arbitrary fixed limits.
Kevin
next prev parent reply other threads:[~2009-10-12 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 13:48 [Qemu-devel] [PATCH 1/2] multiboot: Fix cmdline of modules adam
2009-10-11 13:48 ` [Qemu-devel] [PATCH 2/2] multiboot: Limit number of multiboot modules adam
2009-10-12 10:43 ` Kevin Wolf [this message]
2009-10-12 16:40 ` Adam Lackorzynski
2009-10-14 16:11 ` Adam Lackorzynski
2009-10-19 8:30 ` Kevin Wolf
2009-10-20 18:22 ` Adam Lackorzynski
[not found] ` <m3aazl8y4m.fsf@neno.mitica>
2009-10-21 9:29 ` [Qemu-devel] " Kevin Wolf
2009-10-12 10:28 ` [Qemu-devel] [PATCH 1/2] multiboot: Fix cmdline of modules Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD3085A.1050906@redhat.com \
--to=kwolf@redhat.com \
--cc=adam@os.inf.tu-dresden.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.