All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] mc146818rtc: port rtc to vmstate
Date: Mon, 12 Oct 2009 09:42:13 -0500	[thread overview]
Message-ID: <4AD34045.2040300@codemonkey.ws> (raw)
In-Reply-To: <2aba79ff1c207a21816095f3bcc1d517e373dc4d.1254953960.git.quintela@redhat.com>

Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  hw/mc146818rtc.c |   81 ++++++++++++++++++++----------------------------------
>  1 files changed, 30 insertions(+), 51 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index a9d849b..4086592 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -501,59 +501,11 @@ static void rtc_set_date_from_host(RTCState *s)
>      rtc_set_memory(s, REG_IBM_PS2_CENTURY_BYTE, val);
>  }
>
> -static void rtc_save(QEMUFile *f, void *opaque)
> +static int rtc_post_load(void *opaque, int version_id)
>  {
>      RTCState *s = opaque;
>   

Breaks the build because this is unused...

>  #ifdef TARGET_I386
>          if (rtc_td_hack) {
>              rtc_coalesced_timer_update(s);
>   

In target mips-softmmu.

Regards,

Anthony Liguori

  reply	other threads:[~2009-10-12 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 22:21 [Qemu-devel] [PATCH 0/3] rtc port to VMState (and fix rtc-td hack) Juan Quintela
2009-10-07 22:21 ` [Qemu-devel] [PATCH 1/3] mc145818rtc: fix saving of rtc-td hack properly upgrading the version number Juan Quintela
2009-10-07 22:21 ` [Qemu-devel] [PATCH 2/3] mc146818rtc: port rtc to vmstate Juan Quintela
2009-10-12 14:42   ` Anthony Liguori [this message]
2009-10-07 22:21 ` [Qemu-devel] [PATCH 3/3] mc146818rtc: fix indentation Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD34045.2040300@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.