From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MxM6P-0004NI-Jb
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 10:42:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MxM6L-0004Hn-Pe
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 10:42:21 -0400
Received: from [199.232.76.173] (port=48742 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MxM6L-0004HX-Ki
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 10:42:17 -0400
Received: from mail-qy0-f179.google.com ([209.85.221.179]:45103)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MxM6L-0000uw-9z
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 10:42:17 -0400
Received: by qyk9 with SMTP id 9so12117990qyk.30
	for <qemu-devel@nongnu.org>; Mon, 12 Oct 2009 07:42:16 -0700 (PDT)
Message-ID: <4AD34045.2040300@codemonkey.ws>
Date: Mon, 12 Oct 2009 09:42:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] mc146818rtc: port rtc to vmstate
References: <cover.1254953960.git.quintela@redhat.com>
	<2aba79ff1c207a21816095f3bcc1d517e373dc4d.1254953960.git.quintela@redhat.com>
In-Reply-To: <2aba79ff1c207a21816095f3bcc1d517e373dc4d.1254953960.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  hw/mc146818rtc.c |   81 ++++++++++++++++++++----------------------------------
>  1 files changed, 30 insertions(+), 51 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index a9d849b..4086592 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -501,59 +501,11 @@ static void rtc_set_date_from_host(RTCState *s)
>      rtc_set_memory(s, REG_IBM_PS2_CENTURY_BYTE, val);
>  }
>
> -static void rtc_save(QEMUFile *f, void *opaque)
> +static int rtc_post_load(void *opaque, int version_id)
>  {
>      RTCState *s = opaque;
>   

Breaks the build because this is unused...

>  #ifdef TARGET_I386
>          if (rtc_td_hack) {
>              rtc_coalesced_timer_update(s);
>   

In target mips-softmmu.

Regards,

Anthony Liguori