From: Jonathan Cameron <jic23@cam.ac.uk>
To: Linux Media Mailing List <linux-media@vger.kernel.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: pxa-camera: build error 2.6.32-rc4
Date: Mon, 12 Oct 2009 18:53:49 +0100 [thread overview]
Message-ID: <4AD36D2D.2000202@cam.ac.uk> (raw)
Error was
drivers/media/video/pxa_camera.c: In function 'pxa_camera_wakeup':
drivers/media/video/pxa_camera.c:683: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/media/video/pxa_camera.c:683: error: (Each undeclared identifier is reported only once
drivers/media/video/pxa_camera.c:683: error: for each function it appears in.)
CC [M] drivers/pcmcia/soc_common.o
Line in question is
wake_up(&vb->done);
in pxa_camera_wakeup.
Looks like issue is lack of inclusion of sched.h.
Right now I'm having trouble tracking down why this became and issue since 2.6.32-rc3.
Might be related to
Staging: comedi: Add include of <linux/sched.h> to fix build
which is down to removal of sched.h from poll.h
commmit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
Looks like media/v4l2-dev.h and others include poll.h so I'm guessing
we were original getting it from there.
I'm happy to post a patch but was wondering if anyone else has seen this or has tracked down
exactly what changed, not to mention if this is a more general problem? (or for that matter
already fixed and I just missed it.)
Thanks
Jonathan
next reply other threads:[~2009-10-12 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 17:53 Jonathan Cameron [this message]
2009-10-12 18:01 ` pxa-camera: build error 2.6.32-rc4 Jonathan Cameron
2009-10-12 18:08 ` [PATCH] pxa-camera: Fix missing sched.h Jonathan Cameron
2009-10-12 20:01 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD36D2D.2000202@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.