From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 05/14] repair: reduce byte swapping in scan_freelist
Date: Mon, 12 Oct 2009 15:43:32 -0500 [thread overview]
Message-ID: <4AD394F4.60809@sandeen.net> (raw)
In-Reply-To: <20090902175840.573208011@bombadil.infradead.org>
Christoph Hellwig wrote:
> Store the ag number in a local native endian variable to avoid
> byteswapping
> it over and over again.
>
>
> Signed-off-by: Barry Naujok <bnaujok@sgi.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfsprogs-dev/repair/scan.c
> ===================================================================
> --- xfsprogs-dev.orig/repair/scan.c 2009-08-21 19:03:26.000000000 +0000
> +++ xfsprogs-dev/repair/scan.c 2009-08-21 19:05:32.000000000 +0000
> @@ -943,23 +943,26 @@ scan_freelist(
> {
> xfs_agfl_t *agfl;
> xfs_buf_t *agflbuf;
> + xfs_agnumber_t agno;
> xfs_agblock_t bno;
> int count;
> int i;
>
> + agno = be32_to_cpu(agf->agf_seqno);
> +
> if (XFS_SB_BLOCK(mp) != XFS_AGFL_BLOCK(mp) &&
> - XFS_AGF_BLOCK(mp) != XFS_AGFL_BLOCK(mp) &&
> - XFS_AGI_BLOCK(mp) != XFS_AGFL_BLOCK(mp))
> - set_agbno_state(mp, be32_to_cpu(agf->agf_seqno),
> - XFS_AGFL_BLOCK(mp), XR_E_FS_MAP);
> + XFS_AGF_BLOCK(mp) != XFS_AGFL_BLOCK(mp) &&
> + XFS_AGI_BLOCK(mp) != XFS_AGFL_BLOCK(mp))
> + set_agbno_state(mp, agno, XFS_AGFL_BLOCK(mp), XR_E_FS_MAP);
> +
> if (be32_to_cpu(agf->agf_flcount) == 0)
> return;
> - agflbuf = libxfs_readbuf(mp->m_dev, XFS_AG_DADDR(mp,
> - be32_to_cpu(agf->agf_seqno),
> - XFS_AGFL_DADDR(mp)), XFS_FSS_TO_BB(mp, 1), 0);
> +
> + agflbuf = libxfs_readbuf(mp->m_dev,
> + XFS_AG_DADDR(mp, agno, XFS_AGFL_DADDR(mp)),
> + XFS_FSS_TO_BB(mp, 1), 0);
> if (!agflbuf) {
> - do_abort(_("can't read agfl block for ag %d\n"),
> - be32_to_cpu(agf->agf_seqno));
> + do_abort(_("can't read agfl block for ag %d\n"), agno);
> return;
> }
> agfl = XFS_BUF_TO_AGFL(agflbuf);
> @@ -967,12 +970,11 @@ scan_freelist(
> count = 0;
> for (;;) {
> bno = be32_to_cpu(agfl->agfl_bno[i]);
> - if (verify_agbno(mp, be32_to_cpu(agf->agf_seqno), bno))
> - set_agbno_state(mp, be32_to_cpu(agf->agf_seqno),
> - bno, XR_E_FREE);
> + if (verify_agbno(mp, agno, bno))
> + set_agbno_state(mp, agno, bno, XR_E_FREE);
> else
> do_warn(_("bad agbno %u in agfl, agno %d\n"),
> - bno, be32_to_cpu(agf->agf_seqno));
> + bno, agno);
> count++;
> if (i == be32_to_cpu(agf->agf_fllast))
> break;
> @@ -981,8 +983,7 @@ scan_freelist(
> }
> if (count != be32_to_cpu(agf->agf_flcount)) {
> do_warn(_("freeblk count %d != flcount %d in ag %d\n"), count,
> - be32_to_cpu(agf->agf_flcount),
> - be32_to_cpu(agf->agf_seqno));
> + be32_to_cpu(agf->agf_flcount), agno);
> }
> libxfs_putbuf(agflbuf);
> }
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-12 20:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 17:55 [PATCH 00/14] repair memory usage reductions Christoph Hellwig
2009-09-02 17:55 ` [PATCH 01/14] repair: merge scanfunc_bno and scanfunc_cnt Christoph Hellwig
2009-10-12 16:53 ` Eric Sandeen
2009-10-13 22:13 ` Christoph Hellwig
2009-10-13 23:36 ` Alex Elder
2009-09-02 17:55 ` [PATCH 02/14] repair: reduce byte swap operations in scanfunc_allocbt Christoph Hellwig
2009-10-12 17:18 ` Eric Sandeen
2009-10-13 23:37 ` [PATCH 02/14] repair: reduce byte swap operations inscanfunc_allocbt Alex Elder
2009-09-02 17:55 ` [PATCH 03/14] repair: kill B_IS_META flag Christoph Hellwig
2009-10-12 19:45 ` Eric Sandeen
2009-10-13 22:16 ` Christoph Hellwig
2009-10-13 22:19 ` Eric Sandeen
2009-10-13 23:38 ` Alex Elder
2009-09-02 17:55 ` [PATCH 04/14] repair: split up scanfunc_ino Christoph Hellwig
2009-10-12 20:06 ` Eric Sandeen
2009-10-13 22:19 ` Christoph Hellwig
2009-10-13 22:22 ` Eric Sandeen
2009-10-13 22:23 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 05/14] repair: reduce byte swapping in scan_freelist Christoph Hellwig
2009-10-12 20:43 ` Eric Sandeen [this message]
2009-09-02 17:55 ` [PATCH 06/14] repair: use a btree instead of a radix tree for the prefetch queue Christoph Hellwig
2009-10-21 17:12 ` [PATCH 06/14] repair: use a btree instead of a radix tree for theprefetch queue Alex Elder
2009-11-12 10:04 ` Christoph Hellwig
2009-11-12 23:46 ` Dave Chinner
2009-09-02 17:55 ` [PATCH 07/14] repair: use single prefetch queue Christoph Hellwig
2009-10-21 17:48 ` Alex Elder
2009-11-12 10:09 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 08/14] repair: clean up prefetch tracing Christoph Hellwig
2009-10-21 17:53 ` Alex Elder
2009-09-02 17:55 ` [PATCH 09/14] repair: track logical to physical block mapping more effeciently Christoph Hellwig
2009-10-21 19:06 ` [PATCH 09/14] repair: track logical to physical block mapping moreeffeciently Alex Elder
2009-11-12 10:18 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 10/14] repair: cleanup helpers for tracking block usage Christoph Hellwig
2009-10-21 19:33 ` Alex Elder
2009-11-12 10:21 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 11/14] repair: cleanup alloc/free/reset of the block usage tracking Christoph Hellwig
2009-10-21 20:22 ` [PATCH 11/14] repair: cleanup alloc/free/reset of the block usagetracking Alex Elder
2009-09-02 17:55 ` [PATCH 12/14] repair: switch block usage bitmap to a btree Christoph Hellwig
2009-10-22 16:22 ` Alex Elder
2009-11-12 10:25 ` Christoph Hellwig
2009-09-02 17:55 ` [PATCH 13/14] repair: optimize duplicate extent tracking Christoph Hellwig
2009-10-22 16:41 ` Alex Elder
2009-09-02 17:55 ` [PATCH 14/14] repair: add missing locking in scanfunc_bmap Christoph Hellwig
2009-10-22 16:42 ` Alex Elder
2009-09-03 20:49 ` [PATCH 00/14] repair memory usage reductions Geoffrey Wehrman
2009-09-04 2:57 ` Dave Chinner
2009-09-04 13:37 ` Geoffrey Wehrman
2009-09-04 14:51 ` Christoph Hellwig
2009-09-04 17:24 ` Michael Monnerie
2009-11-12 15:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD394F4.60809@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.