From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mick Jordan <Mick.Jordan@Sun.COM>
Subject: Re: [PATCH 4 of 7] minios: fix minios console
Date: Mon, 12 Oct 2009 15:54:44 -0700
Message-ID: <4AD3B3B4.8050806@Sun.COM>
References: <alpine.DEB.2.00.0910121759540.4616@kaball-desktop>
Reply-To: Mick.Jordan@Sun.COM
Mime-Version: 1.0
Content-Type: text/plain; CHARSET=US-ASCII; format=flowed
Content-Transfer-Encoding: 7BIT
Return-path: <xen-devel-bounces@lists.xensource.com>
In-reply-to: <alpine.DEB.2.00.0910121759540.4616@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 10/12/09 10:20 AM, Stefano Stabellini wrote:
> MiniOS' console_print tries to expand '\n' into "\n\r" in place, causing
> page faults if the string resides in text.
> Use a duplicate of the string instead.
>   
Are you sure this is even necessary? I removed this in my GUK extension 
of MiniOS with no apparent effect. The actual push to remove it was 
observing that when "piping" the output of one GUK (JVM) guest to 
another, the "\n\r" was being treated as two line feeds by the Java 
runtime. Why? Because it is "\r\n" that is historically reduced to "\n", 
and not "\n\r". In any event in the Xen/Unix environment there should be 
no need for the expansion at all. And it really helped to clean up the 
console code.

Mick