All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 2/3] git config: clarify bool types
Date: Tue, 13 Oct 2009 09:09:33 +0200	[thread overview]
Message-ID: <4AD427AD.3010701@drmicha.warpmail.net> (raw)
In-Reply-To: <94a0d4530910121014k666207b9ub38fcecd47641ace@mail.gmail.com>

Felipe Contreras venit, vidit, dixit 12.10.2009 19:14:
> On Mon, Oct 12, 2009 at 3:30 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> Felipe Contreras venit, vidit, dixit 12.10.2009 12:03:
>>> On Mon, Oct 12, 2009 at 8:01 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>
>>>>> The value is what it is, the --bool and --bool-or-int options don't
>>>>> specify the value type, just how it is interpreted. For example: a value
>>>>> of '1' can be interpreted as 'true'.
>>>>
>>>> It is not really about "interpreting", but about showing, isn't it?
>>>
>>> Unless you are setting it, instead of reading it.
>>>
>>
>> I'd still suggest fixing the typo ("interpreted") and spelling out
>> "boolean".
> 
> Oops! You mean s/intepreted/interpreted/?

Yep :)

> 
> If we spell 'boolean' we might as well spell 'integer'; I think bool
> and int are fine.
> 

"int" is at least a standard type name in C, whereas "bool" is not; but,
yes, feel free to spell out "integer", or use "--int or --bool" as it
is, which is a back reference to the corresponding entries for "--int"
and "--bool", where things should be spelled out.

Michael

  reply	other threads:[~2009-10-13  7:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 20:46 [PATCH 0/3] Trivial patches Felipe Contreras
2009-10-11 20:46 ` [PATCH 1/3] Fix a bunch of pointer declarations (codestyle) Felipe Contreras
2009-10-11 20:46   ` [PATCH 2/3] git config: clarify bool types Felipe Contreras
2009-10-11 20:46     ` [PATCH 3/3] user-manual: use 'fast-forward' Felipe Contreras
2009-10-12  5:05       ` Junio C Hamano
2009-10-12 10:05         ` Felipe Contreras
2009-10-12 12:50           ` Michael J Gruber
2009-10-12  5:01     ` [PATCH 2/3] git config: clarify bool types Junio C Hamano
2009-10-12 10:03       ` Felipe Contreras
2009-10-12 12:30         ` Michael J Gruber
2009-10-12 17:14           ` Felipe Contreras
2009-10-13  7:09             ` Michael J Gruber [this message]
2009-10-13 10:02               ` Felipe Contreras
2009-10-11 20:53   ` [PATCH 1/3] Fix a bunch of pointer declarations (codestyle) Thiago Farina
2009-10-11 20:56     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD427AD.3010701@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.