[Qemu-devel] Re: [PATCH] usb-linux: return USB_RET_STALL on -EPIPE

[Anthony Liguori <aliguori@us.ibm.com>]

Paul Bolle wrote:
> 0) This is an attempt to get an issue in usb-linux.c, for which a patch
> was posted about a year ago, finally fixed.
>
> 1) Mark Burkley submitted a "EHCI emulation module" for review in in
> October 2008 (see:
> http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01326.html). No
> EHCI emulation module was ever committed to qemu.
>   

Yeah, it's ashame that noone's followed up with this patch.

> 2) Part of that (large) patch was a fix for a separate issue in
> usb-linux.c. Max Krasnyansky has ACK'ed that fix (see:
> http://lists.gnu.org/archive/html/qemu-devel/2008-11/msg00032.html).
>
> 3) I already asked whether this fix was ready to be committed in last
> April (see:
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01763.html)
>
> 4) Maybe submitting this fix as a separate patch (with a really long
> commit message but without a Signed-off-by) and cc-ing everbody involved
> will help if actually getting this issue fixed.
>   

Yes, separate fixes should always be separate patches.

> Ok. I just tested that change (ie returning STALL instead of NAK on EPIPE)
> with a bunch of devices: USB serial adapter, CF card reader, USB webcam (MS
> VX-3000) and MS USB mouse. All that stuff was hooked up to XP-SP3 and all of
> them are perfectly usable at the same time.
>
> In other words here is my ACK :)
>
> Acked-by: Max Krasnyansky <maxk@qualcomm.com>
> Tested-by: Paul Bolle <pebolle@tiscali.nl>
>   

Someone needs to  provide a Signed-off-by.

> ---
>  usb-linux.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index 9e5d9c4..d712134 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -275,7 +275,9 @@ static void async_complete(void *opaque)
>
>              case -EPIPE:
>                  set_halt(s, p->devep);
> -                /* fall through */
> +		p->len = USB_RET_STALL;
> +		break;
> +
>              default:
>                  p->len = USB_RET_NAK;
>                  break;
>   


-- 
Regards,

Anthony Liguori