All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Robert Gordon <rbg-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: nfs-utils-1.2.0: insecure option and port range checking.
Date: Tue, 13 Oct 2009 14:09:48 -0400	[thread overview]
Message-ID: <4AD4C26C.2030002@RedHat.com> (raw)
In-Reply-To: <ADD0E404-49A2-49AA-A3A1-A7065243E14E-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>



On 10/13/2009 01:56 PM, Robert Gordon wrote:
> 
> I noticed that the insecure option validates that the client port is a
> subset of IPPORT_RESERVED as opposed to just validating it is a valid
> reserved port. The following proposed patch would correct that issue.
> Would anyone care to comment ? ..
> 
> # diff utils/mountd/auth.c utils/mountd/auth.c.orig
> 171a172
>>             (ntohs(caller->sin_port) <  IPPORT_RESERVED/2 ||
> 
What version of nfs-utils are you using and please generate a proper
patch (via gendiff) with a proper 'Signed-off-by:' label...

tia,

steved.

  parent reply	other threads:[~2009-10-13 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 17:56 nfs-utils-1.2.0: insecure option and port range checking Robert Gordon
     [not found] ` <ADD0E404-49A2-49AA-A3A1-A7065243E14E-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org>
2009-10-13 18:07   ` Jeff Layton
2009-10-13 18:09   ` Steve Dickson [this message]
     [not found]     ` <4AD4C26C.2030002-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-13 23:46       ` Robert Gordon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD4C26C.2030002@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rbg-dkEPNP4dzOJBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.