From: Tom Rix <tom@bumblecow.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI DaVinci: Fix DM6467 EVM Compilation Warning
Date: Tue, 13 Oct 2009 20:48:55 -0500 [thread overview]
Message-ID: <4AD52E07.6040109@bumblecow.com> (raw)
In-Reply-To: <1255451834-16775-1-git-send-email-s-paulraj@ti.com>
s-paulraj at ti.com wrote:
> From: Sandeep Paulraj <s-paulraj@ti.com>
>
> Due to new TI boards being added to U-Boot, the hardware.h
> is getting very messy. The warning being fixed is due to
> the EMIF addresses being redefined.
>
> The long term solution(after 2009.11) to this is to
> have SOC specific header files.
>
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> ---
> include/asm-arm/arch-davinci/hardware.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-arm/arch-davinci/hardware.h b/include/asm-arm/arch-davinci/hardware.h
> index ac32510..acf12ea 100644
> --- a/include/asm-arm/arch-davinci/hardware.h
> +++ b/include/asm-arm/arch-davinci/hardware.h
> @@ -71,10 +71,12 @@ typedef volatile unsigned int * dv_reg_p;
> #define DAVINCI_SPI_BASE (0x01c66800)
> #define DAVINCI_GPIO_BASE (0x01c67000)
> #define DAVINCI_VPSS_REGS_BASE (0x01c70000)
> +#if !defined(CONFIG_SOC_DM646X)
> #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE (0x02000000)
> #define DAVINCI_ASYNC_EMIF_DATA_CE1_BASE (0x04000000)
> #define DAVINCI_ASYNC_EMIF_DATA_CE2_BASE (0x06000000)
> #define DAVINCI_ASYNC_EMIF_DATA_CE3_BASE (0x08000000)
> +#endif
> #define DAVINCI_DDR_BASE (0x80000000)
>
> #ifdef CONFIG_SOC_DM644X
You have already pushed this so mostly this is for the future..
This can be cleaned up so the default #defines are set
only if they are not already defined by the board.
Or handled with the board files are you are planning.
Tom
next prev parent reply other threads:[~2009-10-14 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 16:37 [U-Boot] [PATCH] TI DaVinci: Fix DM6467 EVM Compilation Warning s-paulraj at ti.com
2009-10-14 1:48 ` Tom Rix [this message]
2009-10-14 2:23 ` Paulraj, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD52E07.6040109@bumblecow.com \
--to=tom@bumblecow.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.