All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <mike@compulab.co.il>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: OMAP3: add CompuLab CM-T35 module
Date: Wed, 14 Oct 2009 09:52:05 +0200	[thread overview]
Message-ID: <4AD58325.60209@compulab.co.il> (raw)
In-Reply-To: <20091013170841.GR12700@atomide.com>

Tony Lindgren wrote:
> * Mike Rapoport <mike@compulab.co.il> [091013 10:00]:
>> This patch adds basic support for CompuLab CM-T35 module.
>>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---
> 
> <snip>
> 
>> +static struct ehci_hcd_omap_platform_data ehci_pdata = {
>> +
>> +	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
>> +	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
>> +	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>> +
>> +	.phy_reset  = true,
>> +	.reset_gpio_port[0]  = -EINVAL,
>> +	.reset_gpio_port[1]  = -EINVAL,
>> +	.reset_gpio_port[2]  = -EINVAL
>> +};
> 
> This ehci stuff should be done in a separate patch, it's not in
> the mainline tree yet.

Ok.

> Can you please check that your patch will compile OK with the
> mainline tree?

It does with ehci stuff removed... I'm too confused with amount of OMAP trees
and branches.

> Regards,
> 
> Tony
> 

-- 
Sincerely yours,
Mike.


  reply	other threads:[~2009-10-14  7:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 16:16 [PATCH 0/2] ARM: OMAP3: add support for cm-t35 board Mike Rapoport
2009-10-13 16:16 ` [PATCH 1/2] ARM: OMAP3: add CompuLab CM-T35 module Mike Rapoport
2009-10-13 17:08   ` Tony Lindgren
2009-10-14  7:52     ` Mike Rapoport [this message]
2009-10-13 16:16 ` [PATCH 2/2] ARM: OMAP3: cm-t35: add defconfig Mike Rapoport
  -- strict thread matches above, loose matches on Subject: below --
2009-10-14  7:48 [PATCH 0/2 v2] ARM: OMAP3: add support for cm-t35 board Mike Rapoport
2009-10-14  7:48 ` [PATCH 1/2] ARM: OMAP3: add CompuLab CM-T35 module Mike Rapoport
2009-10-19 17:58   ` Tony Lindgren
2009-10-21  6:28 [PATCH 0/2 v3] ARM: OMAP3: add support for cm-t35 board Mike Rapoport
2009-10-21  6:28 ` [PATCH 1/2] ARM: OMAP3: add CompuLab CM-T35 module Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD58325.60209@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.