From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Wei, Gang" <gang.wei@intel.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Append 'nohpet' in dom0 cmdline to prevent dom0 from using HPET
Date: Wed, 14 Oct 2009 12:58:02 -0700 [thread overview]
Message-ID: <4AD62D4A.7030301@goop.org> (raw)
In-Reply-To: <8FED46E8A9CA574792FC7AACAC38FE7714FCC2ED95@PDSMSX501.ccr.corp.intel.com>
On 10/14/09 02:26, Wei, Gang wrote:
> Append 'nohpet' in dom0 cmdline to prevent dom0 from using HPET
>
> Xen is using HPET to wakeup cpu from deep c-states, so the HPET usage in dom0
> must be fobidden. In 2.6.18-xen, the HPET was by default disabled in config
> file. For upstream kernel built for pv dom0, it is not practical to disable dom0
> HPET usage in that way because the same image may be also using as bare metal
> kernerl. So add cmdline option to do this thing for dom0.
>
I think it would be better to unstatic disable_hpet() and call it from
Xen setup. But as far as I can see hpet_init() should never be called
under Xen, because pv_time_ops won't be pointing to it, so there won't
be any attempt to use the hpet.
J
next prev parent reply other threads:[~2009-10-14 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 9:26 [PATCH] Append 'nohpet' in dom0 cmdline to prevent dom0 from using HPET Wei, Gang
2009-10-14 10:07 ` Keir Fraser
2009-10-14 19:58 ` Jeremy Fitzhardinge [this message]
2009-10-15 2:13 ` Wei, Gang
2009-10-15 3:31 ` Wei, Gang
2009-10-15 17:23 ` Jeremy Fitzhardinge
2009-10-16 1:13 ` Wei, Gang
2009-10-16 2:19 ` Wei, Gang
2009-10-16 2:31 ` Jeremy Fitzhardinge
2009-10-16 2:51 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD62D4A.7030301@goop.org \
--to=jeremy@goop.org \
--cc=gang.wei@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.