All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Roland McGrath <roland@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ian Lance Taylor <iant@google.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: linker script syntax nits
Date: Wed, 14 Oct 2009 15:35:41 -0700	[thread overview]
Message-ID: <4AD6523D.5030909@zytor.com> (raw)
In-Reply-To: <20091014221024.EFA79E2F@magilla.sf.frob.com>

On 10/14/2009 03:10 PM, Roland McGrath wrote:
> The following changes since commit 80f506918fdaaca6b574ba931536a58ce015c7be:
>   Linus Torvalds (1):
>         Merge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git topic/x86-lds-nits
> 
> Roland McGrath (1):
>       x86: linker script syntax nits
> 
>  arch/x86/kernel/acpi/realmode/wakeup.lds.S |    4 ++--
>  arch/x86/kernel/vmlinux.lds.S              |   17 ++++++++---------
>  2 files changed, 10 insertions(+), 11 deletions(-)

Severely-Nacked-by: H. Peter Anvin <hpa@zytor.com>

> -	. = ASSERT(_end <= WAKEUP_SIZE, "Wakeup too big!");
>  }
> +
> +ASSERT(_end <= WAKEUP_SIZE, "Wakeup too big!");

Sinkless asserts are broken in older versions of ld.

	-hpa

  reply	other threads:[~2009-10-14 22:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 22:10 [PATCH] x86: linker script syntax nits Roland McGrath
2009-10-14 22:35 ` H. Peter Anvin [this message]
2009-10-15  6:13   ` [tip:x86/urgent] Revert "x86: linker script syntax nits" tip-bot for Ingo Molnar
2009-10-16  5:28   ` [tip:x86/urgent] x86: Document linker script ASSERT() quirk tip-bot for Ingo Molnar
2009-10-15  3:30 ` [PATCH] x86: linker script syntax nits Sam Ravnborg
2009-10-15  6:38   ` Ingo Molnar
2009-10-15 17:17     ` H. Peter Anvin
2009-10-15 18:26       ` Roland McGrath
2009-10-15 18:30         ` H. Peter Anvin
2009-10-15 19:27         ` Sam Ravnborg
2009-10-15  6:18 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD6523D.5030909@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=iant@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.