From: William Allen Simpson <william.allen.simpson@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH 1/4] TCPCT part 1: initial SYN exchange with SYNACK data
Date: Thu, 15 Oct 2009 07:45:55 -0400 [thread overview]
Message-ID: <4AD70B73.2040401@gmail.com> (raw)
In-Reply-To: <20091014.231540.01186298.davem@davemloft.net>
David Miller wrote:
> This callback is generic and isn't designed to take opaque
> data. All the other arguments to this callback are strongly
> typed, and this is on purpose.
>
> You'll need to find another way to implement this.
>
This was the most controversial change, so I made it the first separate
patch to get strong review.
#1 You recently shot down adding a GFP_ATOMIC kref (Adam's original code),
after having approved it a year ago.
#2 The entire struct could be added to all struct request_sock, but you
already rejected adding fewer bytes to the much larger tcp_sock. And that
isn't the best strategy, as request_sock otherwise would not have a cookie
and is intended to be small.
#3 It's not possible to wrap and extend request_sock, as that is already
done by IPv6 and others, causing a conflict. That was suggested by
another maintainer, and I drafted some code last week, but wasn't able to
figure out a non-conflicting code path.
#4 Passing a pointer parameter is the only option left that I've discovered.
Now, you've rejected that as well....
So, lead me to "another way"?
next prev parent reply other threads:[~2009-10-15 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 5:28 [net-next-2.6 PATCH 1/4] TCPCT part 1: initial SYN exchange with SYNACK data William Allen Simpson
2009-10-15 5:32 ` [net-next-2.6 PATCH 2/4] " William Allen Simpson
2009-10-15 5:34 ` [net-next-2.6 PATCH 3/4] " William Allen Simpson
2009-10-15 5:36 ` [net-next-2.6 PATCH 4/4] " William Allen Simpson
2009-10-15 6:17 ` David Miller
2009-10-15 6:15 ` [net-next-2.6 PATCH 1/4] " David Miller
2009-10-15 11:45 ` William Allen Simpson [this message]
2009-10-15 16:29 ` William Allen Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD70B73.2040401@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.