From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC] Remove or convert empty ioctls ?
Date: Thu, 15 Oct 2009 11:22:40 -0400 [thread overview]
Message-ID: <4AD73E40.1010501@garzik.org> (raw)
In-Reply-To: <20091015160109.6d9353e8@lxorguk.ukuu.org.uk>
On 10/15/2009 11:01 AM, Alan Cox wrote:
>> "no particular value" is highly subjective, and I think unprovable,
>> without an exhaustive survey of userland programs interacting with
>> kernel drivers. Userland programs often interact with a -class- of
>> drivers, expecting predictable behavior from a DoThisThing ioctl, with
>> EINVAL or "other weird error code" returned intentionally.
>>
>> Changing the return codes seems quite unwise.
>
> We've changed lots of them to -ENOTTY over the past few years, nobody has
> even noticed (you included ;))
>
> SuS says an unknown ioctl code returns -ENOTTY.
These are not unknown ioctls; they are ioctls that the driver author
close to implement rather than the default (ENOTTY).
Jeff
next prev parent reply other threads:[~2009-10-15 15:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 9:20 [RFC] Remove or convert empty ioctls ? Thomas Gleixner
2009-10-15 12:12 ` Jeff Garzik
2009-10-15 15:01 ` Alan Cox
2009-10-15 15:22 ` Jeff Garzik [this message]
2009-10-15 15:31 ` Alan Cox
2009-10-15 15:35 ` Jeff Garzik
2009-10-15 15:49 ` Alan Cox
2009-10-15 16:03 ` Jeff Garzik
2009-10-15 16:23 ` Thomas Gleixner
2009-10-15 16:28 ` Thomas Gleixner
2009-10-15 15:50 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD73E40.1010501@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.