From: Earl Chew <earl_chew@agilent.com>
To: linux-kernel@vger.kernel.org
Subject: Arithmetic overflow in may_expand_vm()
Date: Thu, 15 Oct 2009 10:24:51 -0700 [thread overview]
Message-ID: <4AD75AE3.80803@agilent.com> (raw)
This code currently reads:
> int may_expand_vm(struct mm_struct *mm, unsigned long npages)
> {
> unsigned long cur = mm->total_vm; /* pages */
> unsigned long lim;
>
> lim = current->signal->rlim[RLIMIT_AS].rlim_cur >> PAGE_SHIFT;
>
> if (cur + npages > lim)
> return 0;
> return 1;
> }
If npages is stupendously large, the failure predicate may
return a false negative due to (cur + npages) overflowing and
wrapping.
I think it's more robustly written as:
if (npages > lim - cur)
return 0;
next reply other threads:[~2009-10-15 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 17:24 Earl Chew [this message]
2009-10-19 7:53 ` Arithmetic overflow in may_expand_vm() Johannes Weiner
2009-10-19 14:43 ` Earl Chew
2009-10-19 23:40 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD75AE3.80803@agilent.com \
--to=earl_chew@agilent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.