From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyVK5-0007yK-A7 for qemu-devel@nongnu.org; Thu, 15 Oct 2009 14:45:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyVK0-0007w7-Rz for qemu-devel@nongnu.org; Thu, 15 Oct 2009 14:45:12 -0400 Received: from [199.232.76.173] (port=39310 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyVK0-0007w2-GM for qemu-devel@nongnu.org; Thu, 15 Oct 2009 14:45:08 -0400 Received: from fg-out-1718.google.com ([72.14.220.158]:4072) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MyVK0-0002km-5D for qemu-devel@nongnu.org; Thu, 15 Oct 2009 14:45:08 -0400 Received: by fg-out-1718.google.com with SMTP id 22so1660940fge.10 for ; Thu, 15 Oct 2009 11:45:06 -0700 (PDT) Message-ID: <4AD76DAC.60605@codemonkey.ws> Date: Thu, 15 Oct 2009 13:45:00 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/10] Introduce qmisc module References: <1255037747-3340-1-git-send-email-lcapitulino@redhat.com> <1255037747-3340-2-git-send-email-lcapitulino@redhat.com> <4AD72B88.2040107@codemonkey.ws> <20091015122622.1f93ea2d@doriath> <4AD74134.3080506@codemonkey.ws> <20091015141732.2eb9328b@doriath> In-Reply-To: <20091015141732.2eb9328b@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Luiz Capitulino wrote: > Great! > > I have some concerns about string parsing though, can we make it very > simple? Like, only valid as keys and not expect anything fancy inside > the string delimiters? > > Otherwise I think it would be easier to make it part of a grammar, > which sounds like a good future improvement. > You know, once we have a json parser, we'll probably just want to turn this into an asprintf() that feeds into the json parser. So just make sure that the format is valid json. In fact, it may be better to name this qobject_from_json(). Regards, Anthony Liguori