Re: [PATCH 2/2] MIPS: Put PGD in C0_CONTEXT for 64-bit R2 processors.

[David Daney <ddaney@caviumnetworks.com>]

Maciej W. Rozycki wrote:
> On Wed, 14 Oct 2009, David Daney wrote:
> 
>> @@ -1406,6 +1424,7 @@ void __cpuinit build_tlb_refill_handler(void)
>>  	case CPU_TX3912:
>>  	case CPU_TX3922:
>>  	case CPU_TX3927:
>> +#ifndef CONFIG_MIPS_PGD_C0_CONTEXT
>>  		build_r3000_tlb_refill_handler();
>>  		if (!run_once) {
>>  			build_r3000_tlb_load_handler();
>> @@ -1413,6 +1432,9 @@ void __cpuinit build_tlb_refill_handler(void)
>>  			build_r3000_tlb_modify_handler();
>>  			run_once++;
>>  		}
>> +#else
>> +		panic("No R3000 TLB refill handler");
>> +#endif
>>  		break;
>>  
>>  	case CPU_R6000:
> 
>  Shouldn't this be #error or suchlike instead?
> 

I don't think so.  It is a runtime check.  The kernel was configured in 
such a manner that those CPUs cannot be supported.  By the time the 
problem is detected, the preprocessor (and compiler in general) have 
already been run.

David Daney


>   Maciej
>