From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MykWK-0002sb-Q4 for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 06:58:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MykWI-0002sD-Uy for grub-devel@gnu.org; Fri, 16 Oct 2009 06:58:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MykWE-0002rZ-9p for grub-devel@gnu.org; Fri, 16 Oct 2009 06:58:50 -0400 Received: from [199.232.76.173] (port=50181 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MykWE-0002rW-4J for grub-devel@gnu.org; Fri, 16 Oct 2009 06:58:46 -0400 Received: from mail-fx0-f228.google.com ([209.85.220.228]:40714) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MykWD-0004Cy-LD for grub-devel@gnu.org; Fri, 16 Oct 2009 06:58:45 -0400 Received: by fxm28 with SMTP id 28so2227249fxm.42 for ; Fri, 16 Oct 2009 03:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=xAzuy/X57UnmoZptJZYA9YFLXaJnNdphuU2EFumSk7g=; b=vusaWEkgno8abx1j3UIEjufayReXwin9SzCQN7Li230YL49iMtomCNzMr4GOg4mNwU KYaKOh0x+jEfT+Ptuo36T7uxtdJN4ot/KRAFiMtXE1yG+n3t4fyzcKA6ditAkjDDO8c8 Z7SqncZnFpLatfYT6FkVePPIHANqSsbgoIL28= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=A9IJpPnSeywbL6P3Zy8RwTd0Phvw/lUbYhPuhAhm6fURR5Y6wL3+VrpHoW6GyJW+bi o9RNK4HBS8nb8LBwos2OgPbyJDjXBHRle68HCZc/syA9pYVN2+zgAED/KUILTDHf6ijm 9bJtaBDSGhqxiRGPHsQw410dU2Tj5dmhKf6RQ= Received: by 10.223.4.214 with SMTP id 22mr222515fas.34.1255690724716; Fri, 16 Oct 2009 03:58:44 -0700 (PDT) Received: from debian.bg45.phnet (hg-public-dock-129-dhcp.ethz.ch [82.130.80.129]) by mx.google.com with ESMTPS id d6sm1430348fga.20.2009.10.16.03.58.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 03:58:42 -0700 (PDT) Message-ID: <4AD851E2.6020104@gmail.com> Date: Fri, 16 Oct 2009 12:58:42 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090812003800.GC8561@thorin> <20090813203736.GH22130@thorin> <20090813210506.GS22130@thorin> In-Reply-To: <20090813210506.GS22130@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: rmh@aybabtu.com Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 10:58:51 -0000 Robert Millan wrote: > On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >>>> We may want to embed more in the future. Actually I think it's not >>>> ad-hoc. Basically partition map defines a function which gives back >>>> the sectors available for embedding. >>>> >>> Is embedding useful elsewhere? >>> >> Yes. Consider a world of checksummed filesystems. In such world you >> can't change the contents of the file by just writing to its blocklist >> since it will break the checksum. Similar problems exist with RAIDs >> and LVMs. On some systems we can't put grub-env in a file. For these >> cases we can embed grub-env somewhere where we can write it with ease >> > > Ok. Feel free to use partmap/ then. But please make sure #ifdefs only > enable those functions where they are going to be used. That'd be > GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them, > this can be changed. > > This patch fixes an important bug - namely overwriting extended partition tables -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git