From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
Subject: Re: [PATCH 08/13] Xen paravirtualised PCI hotplug.
Date: Fri, 16 Oct 2009 11:59:55 +0100
Message-ID: <4AD8522B.2070504@eu.citrix.com>
References: <1255468952-27052-1-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-2-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-3-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-4-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-5-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-6-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-7-git-send-email-konrad.wilk@oracle.com>	<1255468952-27052-8-git-send-email-konrad.wilk@oracle.com>
	<1255468952-27052-9-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1255468952-27052-9-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
List-Id: xen-devel@lists.xenproject.org

Konrad Rzeszutek Wilk wrote:
> The pciback driver adds two new states that are shared by the pcifront
> and pciback. This is a patch pulled from the linux-2.6-xen-sparse tree.
>
> Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  include/xen/interface/io/xenbus.h |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/include/xen/interface/io/xenbus.h b/include/xen/interface/io/xenbus.h
> index 46508c7..9fda532 100644
> --- a/include/xen/interface/io/xenbus.h
> +++ b/include/xen/interface/io/xenbus.h
> @@ -27,8 +27,14 @@ enum xenbus_state
>  	XenbusStateClosing      = 5,  /* The device is being closed
>  					 due to an error or an unplug
>  					 event. */
> -	XenbusStateClosed       = 6
> +	XenbusStateClosed       = 6,
>  
> +	/*
> +	* Reconfiguring: The device is being reconfigured.
> +	*/
> +	XenbusStateReconfiguring = 7,
> +
> +	XenbusStateReconfigured  = 8
>  };
>   
ouch.

what's the usefulness of those 2 new states here ?
the xenbus state is just here to represent the connection status of the 
xenbus device, doesn't reconfiguring/reconfigured state is something 
about the underlying device more than the xenbus device ?

And regarding the xenbus-state state machine, what happen when you reach 8 ?
does every userspace handler need to handle it as a 4 ? if yes why is it 
not 4 ?

-- 
Vincent