From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MykY8-0003Rq-3L for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 07:00:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MykY6-0003Rl-Ii for grub-devel@gnu.org; Fri, 16 Oct 2009 07:00:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MykY1-0003Qv-7n for grub-devel@gnu.org; Fri, 16 Oct 2009 07:00:41 -0400 Received: from [199.232.76.173] (port=50227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MykY1-0003Qs-47 for grub-devel@gnu.org; Fri, 16 Oct 2009 07:00:37 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:49597) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MykY0-0004VP-LC for grub-devel@gnu.org; Fri, 16 Oct 2009 07:00:36 -0400 Received: by fg-out-1718.google.com with SMTP id 16so848416fgg.12 for ; Fri, 16 Oct 2009 04:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=IrfqmKrI2C+K1ks1o+N2u1oUJEmN+rrjrZiaJKRcnCk=; b=v5xMPn9ZzXv4KjS/VBK8NwnTqsx947q6PbkBy+OXHntfV6mKgDrcE7AGTbIRg13BBB S347gy7avTV4F7kaBxHVBo50KuWJWfSXOn2XENKloe7hyjGzKEgeENjLwZ4Qt2QLesTR Rt7c+ad1cmEo9t62gFbFXQAAF//6X4qOEJDzU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=aUNTixiXqM+LVBe/eZ3yHUoRyakrgM3etcPZg6Xw3JI2qAxiMusRhtv/QkfHocJ4ya rVxp2W0SDfiNDWDm5Z6vAwVv/iqvArv7xUa5wSmeU3EbYuh+TEIQp/5XqUSkcuXi0k6/ LtwJJfd2tbEfi5YHHV3eU3TwViiSyUmP/bmh8= Received: by 10.86.247.18 with SMTP id u18mr1162173fgh.43.1255690835311; Fri, 16 Oct 2009 04:00:35 -0700 (PDT) Received: from debian.bg45.phnet (hg-public-dock-129-dhcp.ethz.ch [82.130.80.129]) by mx.google.com with ESMTPS id 4sm908038fgg.3.2009.10.16.04.00.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 04:00:32 -0700 (PDT) Message-ID: <4AD8524F.3090801@gmail.com> Date: Fri, 16 Oct 2009 13:00:31 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090826003427.GD25183@thorin> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Let user specify OpenBSD root device. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 11:00:42 -0000 Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 26, 2009 at 2:34 AM, Robert Millan wrote: > >> On Tue, Aug 25, 2009 at 10:37:33PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> >>> + if (cmd->state[OPENBSD_ROOT_ARG].set) >>> + { >>> + const char *arg = cmd->state[OPENBSD_ROOT_ARG].arg; >>> + int unit, part; >>> + if (*(arg++) != 'w' || *(arg++) != 'd') >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, >>> + "Only device specifications of form " >>> + "wd are supported."); >>> + >>> + unit = grub_strtoul (arg, (char **) &arg, 10); >>> + if (! (arg && *arg >= 'a' && *arg <= 'z')) >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, >>> + "Only device specifications of form " >>> + "wd are supported."); >>> >> Looks like the first error string could be used for both cases, saving >> a few bytes. >> >> This was fixed. Can this patch be comitted before release to avoid changing command syntax after release? >> -- >> Robert Millan >> >> The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and >> how) you may access your data; but nobody's threatening your freedom: we >> still allow you to remove your data and not access it at all." >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel >> >> > > > > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git