From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Myt7c-0005se-1d for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 16:09:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myt7Z-0005pM-0z for grub-devel@gnu.org; Fri, 16 Oct 2009 16:09:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myt7S-0005jj-G4 for grub-devel@gnu.org; Fri, 16 Oct 2009 16:09:51 -0400 Received: from [199.232.76.173] (port=37213 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myt7R-0005ip-Pp for grub-devel@gnu.org; Fri, 16 Oct 2009 16:09:46 -0400 Received: from fg-out-1718.google.com ([72.14.220.156]:48392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myt7R-0004fT-DB for grub-devel@gnu.org; Fri, 16 Oct 2009 16:09:45 -0400 Received: by fg-out-1718.google.com with SMTP id 16so1070029fgg.12 for ; Fri, 16 Oct 2009 13:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=OuIpjkX+BhYdzbZtrX1QJdV+sj3r0R228D43megjIOM=; b=EzYHOsUPB0qEEWQZNH7Nb5Z4sdMHCRf0qqCBxYakhnXpGX+SXdOvWwTyMze1DiO8lU 0JmAX506KsTDjSqYAQvWhd56LeX8dBPku1Uyrd8eeabjRsdOCapiYO+FVyWsYwMJFEGm v7MDsPbGghir7Y5oHjdhQHyYtGf870rd9T16o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=rSb9dR1xEL/ckwZdE72b8g2M8VauHhLgPclG+PBXF5CVzGpnTkP28E8XCz8P9YqCcu oqM4VKVpUkNDDLk/1o1A5+Uu356S8fyBOa1vTuTKKP7bkl8UhAzmzOuwKWyjwRPvts2R goS2i8X5Ys7Im0SOvi0HYePSqS/JNAu3G5pd0= Received: by 10.86.249.30 with SMTP id w30mr1400468fgh.35.1255723784464; Fri, 16 Oct 2009 13:09:44 -0700 (PDT) Received: from debian.bg45.phnet (190-234.203-62.cust.bluewin.ch [62.203.234.190]) by mx.google.com with ESMTPS id 4sm39976fgg.13.2009.10.16.13.09.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 13:09:43 -0700 (PDT) Message-ID: <4AD8D305.5000806@gmail.com> Date: Fri, 16 Oct 2009 22:09:41 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <4AD8514E.2040304@gmail.com> <4AD87D15.7060408@gmail.com> <20091016160156.GA4986@nubol.oskuro.net> <20091016183805.GE7037@thorin> In-Reply-To: <20091016183805.GE7037@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 20:09:54 -0000 Robert Millan wrote: > On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: > >> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> >>> + if (memcmp (tmp_img, "XFSB", 4) == 0) >>> + grub_util_error ("Can't install on XFS."); >>> >> Can this error message give some more detail on what the problem is? >> > > I suggest something like: > > grub_util_warn ("Refusing to overwrite XFS meta-data."); > > This is more informative, and with grub_util_warn() user has an opportunity to > override it if she knows what she's doing. > > Installing with blocklists/to partition is considered backward-compatibility feature. We never supported a config with XFS why we would want bw-compat for it? -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git