From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MytJ3-0007w9-J2 for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 16:21:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MytJ2-0007w1-1U for grub-devel@gnu.org; Fri, 16 Oct 2009 16:21:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MytIx-0007r8-5F for grub-devel@gnu.org; Fri, 16 Oct 2009 16:21:43 -0400 Received: from [199.232.76.173] (port=55167 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MytIx-0007qz-1e for grub-devel@gnu.org; Fri, 16 Oct 2009 16:21:39 -0400 Received: from mail-fx0-f228.google.com ([209.85.220.228]:46016) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MytIw-0006me-Be for grub-devel@gnu.org; Fri, 16 Oct 2009 16:21:38 -0400 Received: by fxm28 with SMTP id 28so2851488fxm.42 for ; Fri, 16 Oct 2009 13:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=LIygrshadpU9Q0YHZLFyvZz264/DOLXWKYZalXsa4YQ=; b=iutRWMezCyHYOhMNaUJ2WpttCxYpZbmMpHtJHoAnzTU2DC+kG/nSo1oB8yVC8DH6/z xCS7C/SsbqN5DNhg0tfmpx2JLydgKUVoeFojxTwaP7aENEpc378ZRn8MDJ/3LLblRP/q 5KCDE2Fb4vcAEgKyvOMvZYF82iSUTcJMkI5So= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=NVO4+htxbiXEynOODKRjqQmDedMBWZfv/usB7aDNd0iVakj1TVVUT9602zn/FAYfZB +9VqdrAjEiMpbAZpXgZLL7791HLX7JZLmRRYtDsMlsF8eVHJ49cRIr8tLjbslhnm1F51 M8cxGxPfHImmQaNy2XfgPKMElxawwRU+ftmCY= Received: by 10.204.8.13 with SMTP id f13mr1663444bkf.150.1255724497189; Fri, 16 Oct 2009 13:21:37 -0700 (PDT) Received: from debian.bg45.phnet (190-234.203-62.cust.bluewin.ch [62.203.234.190]) by mx.google.com with ESMTPS id 15sm265344bwz.8.2009.10.16.13.21.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 13:21:36 -0700 (PDT) Message-ID: <4AD8D5CE.5000602@gmail.com> Date: Fri, 16 Oct 2009 22:21:34 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090826003427.GD25183@thorin> <4AD8524F.3090801@gmail.com> <20091016183131.GA7037@thorin> In-Reply-To: <20091016183131.GA7037@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Let user specify OpenBSD root device. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 20:21:44 -0000 Robert Millan wrote: > On Fri, Oct 16, 2009 at 01:00:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Vladimir 'phcoder' Serbinenko wrote: >> >>> On Wed, Aug 26, 2009 at 2:34 AM, Robert Millan wrote: >>> >>> >>>> On Tue, Aug 25, 2009 at 10:37:33PM +0200, Vladimir 'phcoder' Serbinenko wrote: >>>> >>>> >>>>> + if (cmd->state[OPENBSD_ROOT_ARG].set) >>>>> + { >>>>> + const char *arg = cmd->state[OPENBSD_ROOT_ARG].arg; >>>>> + int unit, part; >>>>> + if (*(arg++) != 'w' || *(arg++) != 'd') >>>>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, >>>>> + "Only device specifications of form " >>>>> + "wd are supported."); >>>>> + >>>>> + unit = grub_strtoul (arg, (char **) &arg, 10); >>>>> + if (! (arg && *arg >= 'a' && *arg <= 'z')) >>>>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, >>>>> + "Only device specifications of form " >>>>> + "wd are supported."); >>>>> >>>>> >>>> Looks like the first error string could be used for both cases, saving >>>> a few bytes. >>>> >>>> >>>> >> This was fixed. Can this patch be comitted before release to avoid >> changing command syntax after release? >> > > Ok. > > Comitted -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git