From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Myu2X-0001Oj-Ef for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 17:08:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myu2W-0001No-7K for grub-devel@gnu.org; Fri, 16 Oct 2009 17:08:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myu2R-0001LD-Gx for grub-devel@gnu.org; Fri, 16 Oct 2009 17:08:43 -0400 Received: from [199.232.76.173] (port=39475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myu2R-0001L5-AL for grub-devel@gnu.org; Fri, 16 Oct 2009 17:08:39 -0400 Received: from mail-fx0-f228.google.com ([209.85.220.228]:44821) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myu2Q-0005nP-EE for grub-devel@gnu.org; Fri, 16 Oct 2009 17:08:39 -0400 Received: by fxm28 with SMTP id 28so2904062fxm.42 for ; Fri, 16 Oct 2009 14:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=2h+HZ5vbz1Zuw5mqi/F6bSbkKH68rWYpBQDa9pdY1Ug=; b=xAXxsik9hzKvxYBf2xaPsvEdPKJAZ5mEAra1erDeN+YY89mFFpcw8JlQzZnPoiKa/h Pcq91en5JIHHcf6bcr3Tbp0HWvO+HCErv5MC4cO1UbKObrQdBLAgfO4cdLCyuaQmXp36 pIjPnZ4iPtVuRE9tyJbTkyjg1CfNCqwMnfxhY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=eQifQCbaUJFKaMtFzshhoPlnsVSfvEN7g7lYBmiyJ3qcF+pF66Xx8sugqYO8KsWwUj 7RPTw9xMhD33XGEkWPQhfTy7dXPjc8AhtsD0xL3Bs6DgI35sUtjO7r4QHsMhm+tBEnRf CB2tbcFZyjhCCLM2xS02HcX9n1wp+mu9cGIrM= Received: by 10.204.141.3 with SMTP id k3mr1715314bku.177.1255727314288; Fri, 16 Oct 2009 14:08:34 -0700 (PDT) Received: from debian.bg45.phnet (190-234.203-62.cust.bluewin.ch [62.203.234.190]) by mx.google.com with ESMTPS id 13sm271455bwz.10.2009.10.16.14.08.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 14:08:33 -0700 (PDT) Message-ID: <4AD8E0CF.9080509@gmail.com> Date: Fri, 16 Oct 2009 23:08:31 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <4AD8514E.2040304@gmail.com> <4AD87D15.7060408@gmail.com> <20091016160156.GA4986@nubol.oskuro.net> <20091016183805.GE7037@thorin> <4AD8D305.5000806@gmail.com> <20091016205258.GA8496@thorin> In-Reply-To: <20091016205258.GA8496@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 21:08:44 -0000 Robert Millan wrote: > On Fri, Oct 16, 2009 at 10:09:41PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: >>> >>> >>>> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: >>>> >>>> >>>>> + if (memcmp (tmp_img, "XFSB", 4) == 0) >>>>> + grub_util_error ("Can't install on XFS."); >>>>> >>>>> >>>> Can this error message give some more detail on what the problem is? >>>> >>>> >>> I suggest something like: >>> >>> grub_util_warn ("Refusing to overwrite XFS meta-data."); >>> >>> This is more informative, and with grub_util_warn() user has an opportunity to >>> override it if she knows what she's doing. >>> >>> >>> >> Installing with blocklists/to partition is considered >> backward-compatibility feature. We never supported a config with XFS why >> we would want bw-compat for it? >> > > Because we can't reliably tell if it's a config with XFS, only the user can. > This is an issue for both MBR or PBR installs. > > Maybe "XFSB" is only a remnant from one of this disk / partition former > lifes. Maybe it's a valid XFS but user no longer cares about it. Or > maybe a DOS-style label was created on top of it, without overwriting the first > 440 bytes. Or maybe another filesystem had overwritten most XFS metadata > but preserved the first block (this is conceivable since other filesystems > tend to avoid using the first block). > > If user has to workaround GRUB heuristics by dd'ing zeros into a partition > before running grub-install, this is a sign GRUB isn't doing the right thing. > > Well, ok. But then I would ask to use a separate --force e.g. --force-destroy-xfs since users and distributions tend to use --force too much -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git