From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Myu6f-0003Rz-Qz for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 17:13:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myu6d-0003OX-MC for grub-devel@gnu.org; Fri, 16 Oct 2009 17:12:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myu6a-0003Fw-34 for grub-devel@gnu.org; Fri, 16 Oct 2009 17:12:59 -0400 Received: from [199.232.76.173] (port=48225 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myu6Z-0003FY-No for grub-devel@gnu.org; Fri, 16 Oct 2009 17:12:55 -0400 Received: from mail-fx0-f228.google.com ([209.85.220.228]:55843) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myu6Z-0006Vd-FC for grub-devel@gnu.org; Fri, 16 Oct 2009 17:12:55 -0400 Received: by fxm28 with SMTP id 28so2908625fxm.42 for ; Fri, 16 Oct 2009 14:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=fZCfz0Ak/tqIVueJ5j5obmekuTwCm4LsqW0UaaTHLT8=; b=L4Wq7KThs09H6C983T9oB0HggNBq/dS8LSxXMGIOrJa96Z5WLgEYSUpR4/U7jl+yva TJFI9Pr6afhcItQcn+GayhwgijAazhO5QJkAOYcGI9C8FBxcCOYWEnSZic94KBp8VfN7 SWy8MUBuXngUXCTnTsAFFlGi0TihukH46NL7c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=O6+l0vGFwabdLJ5W/dOw16YLmyjEPuK2twbwQMQSkmG/vxtszeAaQtAfs8yQVHLZt5 oDkQL6aoyg7h8SjUNyxcb+jyO7rKIQ9ktx+IsHumxxaX4KwrBeRg2B+H7Rt3aZem5Aj/ aZUikmBFSoduuIW4QSGx11YtkayBedgqvzsrE= Received: by 10.103.7.31 with SMTP id k31mr926161mui.48.1255727574421; Fri, 16 Oct 2009 14:12:54 -0700 (PDT) Received: from debian.bg45.phnet (190-234.203-62.cust.bluewin.ch [62.203.234.190]) by mx.google.com with ESMTPS id l19sm1675381fgb.6.2009.10.16.14.12.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 14:12:53 -0700 (PDT) Message-ID: <4AD8E1D4.7090101@gmail.com> Date: Fri, 16 Oct 2009 23:12:52 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090812003800.GC8561@thorin> <20090813203736.GH22130@thorin> <20090813210506.GS22130@thorin> <4AD851E2.6020104@gmail.com> <20091016210722.GA8866@thorin> In-Reply-To: <20091016210722.GA8866@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 21:12:59 -0000 Robert Millan wrote: > On Fri, Oct 16, 2009 at 12:58:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: >>> >>> >>>>>> We may want to embed more in the future. Actually I think it's not >>>>>> ad-hoc. Basically partition map defines a function which gives back >>>>>> the sectors available for embedding. >>>>>> >>>>>> >>>>> Is embedding useful elsewhere? >>>>> >>>>> >>>> Yes. Consider a world of checksummed filesystems. In such world you >>>> can't change the contents of the file by just writing to its blocklist >>>> since it will break the checksum. Similar problems exist with RAIDs >>>> and LVMs. On some systems we can't put grub-env in a file. For these >>>> cases we can embed grub-env somewhere where we can write it with ease >>>> >>>> >>> Ok. Feel free to use partmap/ then. But please make sure #ifdefs only >>> enable those functions where they are going to be used. That'd be >>> GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them, >>> this can be changed. >>> >>> >>> >> This patch fixes an important bug - namely overwriting extended >> partition tables >> > > Is there a simpler way to resolve this? I don't object to the > restructuring you propose, but it seems too intrusive to do this > just a few hours before we release 1.97. > > Yes. It's my concern too. Solving this requires metadata info form partition map which is normally hidden and new code may have undiscovered bugs. On the other hand already present code has a bug but which is unlikely to be triggered. As a simple alternative one could keep current check + enumerte entries in MBR - this should be enough. -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git