From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 2/2] have restart return error if error Date: Fri, 16 Oct 2009 20:15:52 -0400 Message-ID: <4AD90CB8.5050307@librato.com> References: <20091015184935.GB30490@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091015184935.GB30490-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Linux Containers List-Id: containers.vger.kernel.org Serge E. Hallyn wrote: > I still need this for cr_tests/userns/run_simple.sh to succeed. > All tests pass with this patch applied. > But this is not the intended behavior. The coordinator will: 1) If restart fails, exit with an error status (>0) 2) If restart succeeds, exit immediately with status 0 (--no-wait), or (by default) wait for the restart root-task to exit, and then exit with success status 0, regardless of the exit status (or reason) of the restarted root-task. What you want is that the coordinator instead will report the exit status of the restart root-task. You can use the --copy-status command line switch for that. The intended behavior is that if the restarted root-task died due to a signal, then so will the coordinator (if --copy-status is requested). I now see that this part needs a small fix - to ensure that the signal is not handled by the coordinator. Will fix that. Oren. > Signed-off-by: Serge E. Hallyn > --- > restart.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/restart.c b/restart.c > index cb81293..fa786ef 100644 > --- a/restart.c > +++ b/restart.c > @@ -780,7 +780,7 @@ static int ckpt_parse_status(int status, int mimic, int verbose) > } > } > > - return 0; > + return ret; > } > > static int ckpt_collect_child(struct ckpt_ctx *ctx)