From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz5Hl-00087P-JE for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 05:09:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz5Hj-000875-0m for grub-devel@gnu.org; Sat, 17 Oct 2009 05:09:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz5Hd-00086V-PA for grub-devel@gnu.org; Sat, 17 Oct 2009 05:09:10 -0400 Received: from [199.232.76.173] (port=42063 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz5Hd-00086S-LO for grub-devel@gnu.org; Sat, 17 Oct 2009 05:09:05 -0400 Received: from fg-out-1718.google.com ([72.14.220.158]:24215) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mz5Ha-0003PI-9j; Sat, 17 Oct 2009 05:09:02 -0400 Received: by fg-out-1718.google.com with SMTP id 16so1228423fgg.12 for ; Sat, 17 Oct 2009 02:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=qbN1yVXtwUnPHOhox9QATEd/lFa1fYJvvobBH/VgyBM=; b=jKP4v3YwUChdv1fZEuusyVJjqyti4wcQbERxmLsPLPuk80OVNb6mndCX4bvGfOgdj8 tQgeHECUAIz4yCDx0PgChev2/hD4EyETR8TDIpGk6r3Cm6gV4eWo03uXgoU3ekjfp63U tqpHnfa4eFKdl9R4K2SrLwFXBsnR61SXoowKs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=RiIYu8w37+cix3fqaiz8rA8Tx2hQ5/LKhpXyqTW4p3RviGJ22g18cOZaCLkxpVyzqy 3iHnVFW+p3V5nvglqhxTpNhE2vbuvFTetGcYm+xHDYsRBOhTEChA8dKdixXoYqHvSGHX d89AjmTVH4Ft6enGes1fe1B7bGrtMx76psKIk= Received: by 10.86.251.40 with SMTP id y40mr1702781fgh.57.1255770540504; Sat, 17 Oct 2009 02:09:00 -0700 (PDT) Received: from debian.bg45.phnet (190-234.203-62.cust.bluewin.ch [62.203.234.190]) by mx.google.com with ESMTPS id l12sm261078fgb.7.2009.10.17.02.08.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Oct 2009 02:08:59 -0700 (PDT) Message-ID: <4AD989A9.6040800@gmail.com> Date: Sat, 17 Oct 2009 11:08:57 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Pavel Roskin References: <20091012.032838.82254107.davem@davemloft.net> <4AD70E53.80004@gmail.com> <1255646501.13480.32.camel@mj> <20091016.054440.193711272.davem@davemloft.net> <1255742496.2746.26.camel@mj> In-Reply-To: <1255742496.2746.26.camel@mj> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: grub-devel@gnu.org, bean123ch@gmail.com, David Miller Subject: Re: powerpc/sparc problems X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 09:09:11 -0000 Pavel Roskin wrote: > On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote: > >> From: Pavel Roskin >> Date: Thu, 15 Oct 2009 18:41:41 -0400 >> >> >>> This makes me think that checks for __bswapsi2 and __bswapdi2 will fail >>> on Sparc64, even if those functions are present and even if >>> --disable-werror is used. >>> >> They worked perfectly fine for me on a real system with >> a real compiler and glibc. >> >> If you're going to use cross compilation to test, use >> a full cross toolset and glibc build not some hacked >> up uclibc thing. >> > > I have tested the current GRUB on PowerPC. It's Fedora 11 with a real > glibc. I added __ashldi3 to the arguments of AC_CHECK_FUNCS. The check > fails. Yet __ashldi3 is present in libgcc and is exported > unconditionally. > > The reason is that -nostdlib is added to CFLAGS immediately above > AC_CHECK_FUNCS. -nostdlib disables linking against libgcc. > > I believe the checks for __bswapsi2 __bswapdi2 would fail on sparc64 for > the same reason. > > Also, I believe the effect of -Werror on the test will be seen on > sparc64. Adding -Werror should be after all tests and there should be a > big warning in configure.ac telling not to add tests after that point. > > >> I also believe that even if it still fails for you, >> native building is more important to work than cross >> building situations. >> > > It is a native build and the current code. > > The whole reason I removed the checks is because they stopped working > correctly when the target libc requirement was eliminated. Restoring > the checks without removing -nostdlib not going to help. > > I'm surprised that my code is being reverted immediately before the > release and the result is not tested. It's one thing to revert the code > that has just been committed, and it's entirely different when the code > has been in the repository for months. > > I've tested only the code as it was for powerpc. I'm sorry that I haven't checked sparc64 part but I haven't yet installed sparc64 cross-compile (it's unavailable from emdebian and compiling it oneself is painful) -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git