From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz7hK-0001Vo-Pa for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 07:43:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz7hJ-0001Uh-Mg for grub-devel@gnu.org; Sat, 17 Oct 2009 07:43:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz7hF-0001Qm-QI for grub-devel@gnu.org; Sat, 17 Oct 2009 07:43:45 -0400 Received: from [199.232.76.173] (port=48892 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz7hF-0001QX-Ks for grub-devel@gnu.org; Sat, 17 Oct 2009 07:43:41 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:35303) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mz7hF-0007zS-BC for grub-devel@gnu.org; Sat, 17 Oct 2009 07:43:41 -0400 Received: by fg-out-1718.google.com with SMTP id e21so605897fga.12 for ; Sat, 17 Oct 2009 04:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=ayXC7XEc7ricyb0iKVuIEQhTIBFwrU2wPlmht1irXxM=; b=efONE3hyZeEJhsdTa5xK74vMU0izniWwQCW6vuiBJjl1MHrmBoq7KncnJXbj1+a3dV /FoufelwIgrTojPywskicK1GlzgCnmGk2e3WBiewj6Wdt66iVH5FW+wstVNIHCJVCJ1z HA1gOHSNJE9pcrfMOVtFFZnOwyGMwTERt/bF8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=Ohcn4qLKMO5SGyxrZ8IqYNFHVY/ygkKsX1k/Cq0FPzHoEFJJd6YAUeYrhhz/vqfAVj 61SlRAULUTc381VsncqJ0cwBu2g78gFxf2xqKxWc9Xi9KW3qyY5a3/F+c8+mWrsMUWi0 qwEebNVqwh9Td1LbsgAHVfY/9QjxxCo0JE6ts= Received: by 10.86.251.6 with SMTP id y6mr1847703fgh.24.1255779820622; Sat, 17 Oct 2009 04:43:40 -0700 (PDT) Received: from debian.bg45.phnet (50-157.203-62.cust.bluewin.ch [62.203.157.50]) by mx.google.com with ESMTPS id e20sm63993fga.10.2009.10.17.04.43.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Oct 2009 04:43:39 -0700 (PDT) Message-ID: <4AD9ADE9.3020004@gmail.com> Date: Sat, 17 Oct 2009 13:43:37 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <4AD8514E.2040304@gmail.com> <4AD87D15.7060408@gmail.com> <20091016160156.GA4986@nubol.oskuro.net> <20091016183805.GE7037@thorin> <4AD8D305.5000806@gmail.com> <20091016205258.GA8496@thorin> <4AD8E0CF.9080509@gmail.com> <20091016215343.GA9378@thorin> <4AD8F11D.1030007@gmail.com> <20091017112545.GA3556@thorin> In-Reply-To: <20091017112545.GA3556@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 11:43:46 -0000 Robert Millan wrote: > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> 2009-10-16 Vladimir Serbinenko >> >> + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. >> + (options): New option --destroy-xfs. >> + (main): Handle --destroy-xfs. >> > > I gave this some more thought, and I think this could be less ad-hoc. We're > treating XFS as if it were a "weird", unique thing just because it isn't biased > towards DOS-style boot like most filesystems are. > > Instead, I've done something more generic, using our standard filesystem > probing engine which should be more reliable than a single memcmp. > > The danger is that fs_probe may reject filesystem as valid just because it's newer than expected. > I propose the attached patch. > > > ------------------------------------------------------------------------ > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git