All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency
Date: Sun, 18 Oct 2009 09:29:10 +0200	[thread overview]
Message-ID: <4ADAC3C6.7050905@dev.mellanox.co.il> (raw)
In-Reply-To: <20091016120154.GO20210@me>

Sasha Khapyorsky wrote:
> On 00:05 Fri 16 Oct     , Yevgeny Kliteynik wrote:
>> If I remember it correctly, there's an INFO message
>> in the ucast mgr saying something like "switches
>> configured for unicast" or "<routing engine name>
>> tables configured", or something like that (I don't
>> have access to the code right now).
> 
> Yes, and there a needs of INFO level is also questionable IMHO.
> 
>> So I wanted to see one more line
> 
> There are more than one:
> 
> $ grep OSM_LOG_INFO opensm/osm_ucast_cache.c | wc -l 
> 19

That's true, but only one of them may be printed
each time the ucast manager runs.

-- Yevgeny

>> that says that
>> cache is not applicable.
> 
> We don't need an extra lines, one line instead (as I did in the posted
> patch) is enough.
> 
> Sasha
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2009-10-18  7:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 13:36 [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Hal Rosenstock
     [not found] ` <20091015133639.GB8041-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-10-15 19:26   ` Sasha Khapyorsky
2009-10-15 19:43     ` Hal Rosenstock
     [not found]       ` <f0e08f230910151243o12ec4fffv70f6a278667f55e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-15 20:54         ` Sasha Khapyorsky
2009-10-15 22:00     ` [PATCH] opensm/osm_ucast_cache: reduce OSM_LOG_INFO debug printouts Sasha Khapyorsky
2009-10-15 22:05     ` [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Yevgeny Kliteynik
     [not found]       ` <4AD79CBC.10606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2009-10-16 12:01         ` Sasha Khapyorsky
2009-10-18  7:29           ` Yevgeny Kliteynik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADAC3C6.7050905@dev.mellanox.co.il \
    --to=kliteyn-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.