From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH 03/12] Add udev rule
Date: Mon, 19 Oct 2009 09:25:03 -0500
Message-ID: <4ADC76BF.9050308@codemonkey.ws>
References: <20091019105923.3988.42243.stgit@mchn012c.ww002.siemens.net> <20091019105924.3988.4209.stgit@mchn012c.ww002.siemens.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from gv-out-0910.google.com ([216.239.58.184]:32527 "EHLO
	gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756195AbZJSOZG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 Oct 2009 10:25:06 -0400
Received: by gv-out-0910.google.com with SMTP id r4so377544gve.37
        for <kvm@vger.kernel.org>; Mon, 19 Oct 2009 07:25:08 -0700 (PDT)
In-Reply-To: <20091019105924.3988.4209.stgit@mchn012c.ww002.siemens.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Jan Kiszka wrote:
> Ported from OpenSUSE: Provide an udev rule that not only sets the group
> of /dev/kvm but also triggers automatic loading of the kernel modules
> during boot.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
>  Makefile             |    1 +
>  scripts/65-kvm.rules |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
>  create mode 100644 scripts/65-kvm.rules
>
> diff --git a/Makefile b/Makefile
> index 8314833..8614449 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -54,6 +54,7 @@ install:
>  		if [ -f "$$i" ]; then mv "$$i" "$$i.orig"; fi; \
>  	done
>  	/sbin/depmod -a $(DEPMOD_VERSION) -b $(DESTDIR)
> +	install -m 644 -D scripts/65-kvm.rules $(DESTDIR)/etc/udev/rules.d/65-kvm.rules
>   

I believe F12 is installing it 666.  If we think it's safe, it's 
probably the right thing to do.

Regards,

Anthony Liguori