From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 03/12] Add udev rule
Date: Mon, 19 Oct 2009 16:36:19 +0200 [thread overview]
Message-ID: <4ADC7963.10008@siemens.com> (raw)
In-Reply-To: <4ADC76BF.9050308@codemonkey.ws>
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Ported from OpenSUSE: Provide an udev rule that not only sets the group
>> of /dev/kvm but also triggers automatic loading of the kernel modules
>> during boot.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Makefile | 1 +
>> scripts/65-kvm.rules | 2 ++
>> 2 files changed, 3 insertions(+), 0 deletions(-)
>> create mode 100644 scripts/65-kvm.rules
>>
>> diff --git a/Makefile b/Makefile
>> index 8314833..8614449 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -54,6 +54,7 @@ install:
>> if [ -f "$$i" ]; then mv "$$i" "$$i.orig"; fi; \
>> done
>> /sbin/depmod -a $(DEPMOD_VERSION) -b $(DESTDIR)
>> + install -m 644 -D scripts/65-kvm.rules $(DESTDIR)/etc/udev/rules.d/65-kvm.rules
>>
>
> I believe F12 is installing it 666. If we think it's safe, it's
> probably the right thing to do.
Err, you mean /dev/kvm, not this rules file, right?
Well, in theory it should be safe, but I would currently leave this
decision to the person finally building a package out of kvm-kmod or
doing some post-install adjustment on a concrete system. Better safe
than sorry, specifically as kvm-kmod may contain the latest bleeding edge.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2009-10-19 14:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 10:59 [PULL REQUEST] kvm-kmod Jan Kiszka
2009-10-19 10:59 ` [PATCH 04/12] Fix build without CONFIG_MMU_NOTIFIER Jan Kiszka
2009-10-19 10:59 ` [PATCH 08/12] Cleanup unused CONFIG_KVM_TRACE control Jan Kiszka
2009-10-19 10:59 ` [PATCH 05/12] Fix kvm_vma_kernel_pagesize for pre-2.6.27 kernels Jan Kiszka
2009-10-19 10:59 ` [PATCH 07/12] Define X86_FEATURE_GBPAGES if missing Jan Kiszka
2009-10-19 10:59 ` [PATCH 01/12] Provide schedule_hrtimeout for pre-2.6.28 kernels Jan Kiszka
2009-10-19 10:59 ` [PATCH 06/12] Add compat version of native_read_tsc Jan Kiszka
2009-10-19 10:59 ` [PATCH 10/12] Add compat version of hlist_del_init_rcu Jan Kiszka
2009-10-19 10:59 ` [PATCH 02/12] Use DESTDIR consitently on installation Jan Kiszka
2009-10-19 10:59 ` [PATCH 09/12] Drop now unused config.kbuild Jan Kiszka
2009-10-19 10:59 ` [PATCH 03/12] Add udev rule Jan Kiszka
2009-10-19 13:19 ` Michael Tokarev
2009-10-19 13:25 ` Jan Kiszka
2009-10-19 13:28 ` Luca Tettamanti
2009-10-19 13:34 ` Jan Kiszka
2009-10-19 14:25 ` Anthony Liguori
2009-10-19 14:36 ` Jan Kiszka [this message]
2009-10-19 15:04 ` Anthony Liguori
2009-10-19 10:59 ` [PATCH 11/12] x86: Install compat wrapper for thread_struct.debugreg Jan Kiszka
2009-10-19 10:59 ` [PATCH 12/12] Update source link Jan Kiszka
2009-10-19 19:37 ` [PULL REQUEST] kvm-kmod Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADC7963.10008@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.