From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH v2] Allow guests to register secondary
	vcpu_time_info
Date: Tue, 20 Oct 2009 07:16:59 +0900
Message-ID: <4ADCE55B.8030705@goop.org>
References: <C70205CB.17E32%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C70205CB.17E32%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 10/19/09 20:02, Keir Fraser wrote:
> On 16/10/2009 15:34, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
>
>   
>> On 10/12/09 14:08, Keir Fraser wrote:
>>     
>>> You'll send me a simplified version of this that doesn't need to support
>>> guest update of the version field, right?
>>>   
>>>       
>> Here's the simplified version.  But I'm wondering if it should do the
>> proper version update with write barriers to make it the same as the
>> normal vcpu_time_info update protocol.
>>     
> I fixed this and applied as c/s 20339. Take a look.
>   

Looks OK.  One thing: if it's using __copy_to_guest, should it first
test the handle with guest_handle_okay()?

    J