Re: Nested VMX support v3

[Avi Kivity <avi@redhat.com>]

On 10/15/2009 11:41 PM, oritw@il.ibm.com wrote:
> Avi,
> We have addressed all of the comments, please apply.
>
> The following patches implement nested VMX support. The patches enable a guest
> to use the VMX APIs in order to run its own nested guest (i.e., enable running
> other hypervisors which use VMX under KVM). The current patches support running
> Linux under a nested KVM using shadow page table (with bypass_guest_pf
> disabled). SMP support was fixed.  Reworking EPT support to mesh cleanly with
> the current shadow paging design per Avi's comments is a work-in-progress.
>    

Why is bypass_guest_pf disabled?

> The current patches only support a single nested hypervisor, which can only run
> a single guest (multiple guests are work in progress). Only 64-bit nested
> hypervisors are supported.
>    

Multiple guests and 32-bit support are merge requirements.  As far as I 
can tell there shouldn't be anything special required to support them?


> vpid allocation will be updated with the multiguest support (work in progress).
> We are working on fixing the cr0.TS handling, it works for nested kvm by not
> for vmware server.
>    

Please either drop or fix vpid before merging.  What's wrong with 
cr0.ts?  I'd like to see that fixed as well.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.